From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 582E5C636CC for ; Wed, 15 Feb 2023 15:08:54 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSJOe-00043n-D9; Wed, 15 Feb 2023 10:08:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSJOb-00043J-S7 for qemu-devel@nongnu.org; Wed, 15 Feb 2023 10:08:33 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSJOZ-00066E-Rg for qemu-devel@nongnu.org; Wed, 15 Feb 2023 10:08:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676473710; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V0ZgDYaw+x5g6FuOj9YLfRimCSsbouVqmz3s/TQg94g=; b=QhJRDCKXcm7S5+mWdvYizfVgH9lWzBCOcstPfkkpHMU7EJiwyAPZHQlv4bSAa92jTA0O0J ionXGZhtmJSYu54qS/sFLSJSgOSvHzQO+tLEAbrG00Q7LdXDCVhSU8Jq0SepxbsTbopByG xogaNpMIEF4h0ODxqCDPy3TnI6/1t+k= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-144-ORi2_mr2PySM61cjWKmeYw-1; Wed, 15 Feb 2023 10:08:27 -0500 X-MC-Unique: ORi2_mr2PySM61cjWKmeYw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A4D2A857AA2; Wed, 15 Feb 2023 15:08:26 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.254]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7D24340B40C9; Wed, 15 Feb 2023 15:08:23 +0000 (UTC) Date: Wed, 15 Feb 2023 15:08:20 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: Christian Schoenebeck , Dorinda Bassey , qemu-devel@nongnu.org, kraxel@redhat.com, armbru@redhat.com, pbonzini@redhat.com, wtaymans@redhat.com Subject: Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU Message-ID: References: <20230215085102.415053-1-dbassey@redhat.com> <5159868.WgR6L5i3FV@silver> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Feb 15, 2023 at 06:11:12PM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Feb 15, 2023 at 6:09 PM Christian Schoenebeck > wrote: > > > > On Wednesday, February 15, 2023 2:18:50 PM CET Marc-André Lureau wrote: > > > Hi > > > > > > On Wed, Feb 15, 2023 at 12:51 PM Dorinda Bassey wrote: > > > > > > > > This commit adds a new audiodev backend to allow QEMU to use Pipewire as > > both an audio sink and source. This backend is available on most systems. > > > > > > > > > > Hmm, I would rather have less audio (and ui) backends in QEMU. (for > > > audio, if I could introduce and keep only one, that would be > > > GStreamer: to remove the others..) > > > > > > What is the main advantage compared to using the ALSA backend? (I > > > assume pipewire depends on ALSA anyway on Linux) > > > > I think it does make sense to add Pipewire. Apparently it gains popularity. > > My point is that pipewire has ALSA plugin (and also pulseaudio compat > library etc). So why add another back in QEMU? Every layer in the stack has potential to impact the audio quality. Even if its possible to wire up QEMU to pipewire via ALA/pulseaudio, it wouldn't surprise me if its more reliable (in terms of avoiding glitches/latency) to natively speak pipewire With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|