From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE7D0C4332F for ; Mon, 17 Oct 2022 12:41:45 +0000 (UTC) Received: from localhost ([::1]:59798 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1okPRA-0006Pp-QQ for qemu-devel@archiver.kernel.org; Mon, 17 Oct 2022 08:41:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okPGv-0000UH-TD for qemu-devel@nongnu.org; Mon, 17 Oct 2022 08:31:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:26813) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okPGk-0000zT-El for qemu-devel@nongnu.org; Mon, 17 Oct 2022 08:31:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666009857; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=qt1MScKBIAE4nQjp3OcaKdfyMxYCwPUD6g1XwILevUw=; b=IBbUeX6hjptb52EAE5W9FnWsFKL5AzoK7jxA7vusPBbJvJOMYJ4MP3d8YaAzZzuNRmZuoj 2nyoOcWqNeF7aPVCNdI8/qUOmOt+Wb7A7FCkStG0wZw+w7ep0cmCDldngmxSF0NZLozeMC aKNfYCE2O1WArGhafuXgMWCsBMs5e4I= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-381-RG7y__3aOb6Hpoh2t72Izw-1; Mon, 17 Oct 2022 08:30:54 -0400 X-MC-Unique: RG7y__3aOb6Hpoh2t72Izw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CFC73832D3C; Mon, 17 Oct 2022 12:30:53 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.113]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3D1CAC15BB9; Mon, 17 Oct 2022 12:30:52 +0000 (UTC) Date: Mon, 17 Oct 2022 13:30:49 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Bin Meng Cc: Paolo Bonzini , Peter Maydell , Stefan Hajnoczi , Thomas Huth , Alex =?utf-8?Q?Benn=C3=A9e?= , Richard Henderson , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , "qemu-devel@nongnu.org Developers" , Bin Meng , =?utf-8?Q?Cl=C3=A9ment?= Chigot Subject: Re: [PATCH 49/51] io/channel-watch: Fix socket watch on Windows Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.7 (2022-08-07) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.255, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Oct 17, 2022 at 08:21:37PM +0800, Bin Meng wrote: > +more people > > On Tue, Oct 11, 2022 at 6:42 PM Bin Meng wrote: > > > > Hi Paolo, > > > > On Thu, Oct 6, 2022 at 11:03 AM Bin Meng wrote: > > > > > > Hi Paolo, > > > > > > On Wed, Sep 28, 2022 at 2:10 PM Bin Meng wrote: > > > > > > > > Hi Paolo, > > > > > > > > On Wed, Sep 21, 2022 at 9:02 AM Bin Meng wrote: > > > > > > > > > > On Wed, Sep 14, 2022 at 4:08 PM Bin Meng wrote: > > > > > > > > > > > > On Wed, Sep 7, 2022 at 1:07 PM Bin Meng wrote: > > > > > > > It seems to me that resetting the event twice (one time with the > > > > > > > master Gsource, and the other time with the child GSource) causes some > > > > > > > bizarre behavior. But MSDN [1] says > > > > > > > > > > > > > > "Resetting an event that is already reset has no effect." > > > > > > > > > > > > > > [1] https://docs.microsoft.com/en-us/windows/win32/api/synchapi/nf-synchapi-resetevent > > > > > > > > > > > > > > > > > > > Paolo, any comments about this issue? > > > > > > > > > > v2 series has been sent out, and this patch remains unchanged. > > > > > > > > > > Paolo, still would appreciate your comments. > > > > > > > > Ping? > > > > > > Ping? Can you please comment?? > > > > Ping? > > Paolo remains silent. Please let me know who else could approve this > change. Thanks. Given there has been plenty of time for objecting, I'll queue this patch on the basis that you've tested it on a real Windows host and found it better than what we have today. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|