From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B719C433FE for ; Tue, 18 Oct 2022 09:20:13 +0000 (UTC) Received: from localhost ([::1]:36830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1okilg-0003uW-BU for qemu-devel@archiver.kernel.org; Tue, 18 Oct 2022 05:20:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33920) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okiOY-0003mm-BM for qemu-devel@nongnu.org; Tue, 18 Oct 2022 04:56:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:44029) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okiOR-0006WC-Hx for qemu-devel@nongnu.org; Tue, 18 Oct 2022 04:56:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666083370; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b8016WB24gIQIat0c3fZKPOpr5keGvTlQm6Ua5hRFFo=; b=ddeP9T4FgFoVA+VVSq1nOdm2/E9Q8o2OXfjsAUaNoCeBiuXmTR0XhyHWKFiwI/gFLeV8P5 FpRwtHRmttOAnYbgxX4j6ANWGbIoSTRNybHrO7zF98OGfeMiNmB+JPGFBVey9TTDKXnVfI zHkVv8XZUwySiLDFDjx8jpkyglThnpY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-447-QFn00bF1PqCEGQy4NFhuAg-1; Tue, 18 Oct 2022 04:56:09 -0400 X-MC-Unique: QFn00bF1PqCEGQy4NFhuAg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C0A2B38164C4; Tue, 18 Oct 2022 08:56:08 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.86]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 69B31404CD80; Tue, 18 Oct 2022 08:56:07 +0000 (UTC) Date: Tue, 18 Oct 2022 09:56:04 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Nikolay Borisov Cc: dgilbert@redhat.com, qemu-devel@nongnu.org, jfehlig@suse.com, Claudio.Fontana@suse.com, dfaggioli@suse.com Subject: Re: [PATCH v2 01/11] migration: support file: uri for source migration Message-ID: References: <20221010133408.3214433-1-nborisov@suse.com> <20221010133408.3214433-2-nborisov@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221010133408.3214433-2-nborisov@suse.com> User-Agent: Mutt/2.2.7 (2022-08-07) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.255, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Oct 10, 2022 at 04:33:58PM +0300, Nikolay Borisov wrote: > Implement support for a "file:" uri so that a migration can be initiated > directly to a file from QEMU. > > Signed-off-by: Nikolay Borisov > --- > migration/file.c | 23 +++++++++++++++++++++++ > migration/file.h | 9 +++++++++ > migration/meson.build | 1 + > migration/migration.c | 3 +++ > 4 files changed, 36 insertions(+) > create mode 100644 migration/file.c > create mode 100644 migration/file.h Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|