From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Brad Smith <brad@comstyle.com>
Cc: Warner Losh <imp@bsdimp.com>, Kyle Evans <kevans@freebsd.org>,
Ed Maste <emaste@freebsd.org>, Li-Wen Hsu <lwhsu@freebsd.org>,
Alex Benn_e <alex.bennee@linaro.org>,
Philippe Mathieu-Daud_ <f4bug@amsat.org>,
Thomas Huth <thuth@redhat.com>,
Wainer dos Santos Moschetta <wainersm@redhat.com>,
Beraldo Leal <bleal@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v2] tests: Add sndio to the FreeBSD CI containers / VM
Date: Mon, 10 Oct 2022 09:50:24 +0100 [thread overview]
Message-ID: <Y0Pc0NQQVrXDPgCH@redhat.com> (raw)
In-Reply-To: <56a8c363-d2f2-3aa5-6b35-5c11cc967bf8@comstyle.com>
On Fri, Oct 07, 2022 at 06:27:29PM -0400, Brad Smith wrote:
> On 10/7/2022 4:33 PM, Warner Losh wrote:
> >
> >
> > On Fri, Oct 7, 2022 at 1:21 AM Brad Smith <brad@comstyle.com> wrote:
> >
> > tests: Add sndio to the FreeBSD CI containers / VM
> >
> > ---
> > .gitlab-ci.d/cirrus/freebsd-12.vars | 2 +-
> > .gitlab-ci.d/cirrus/freebsd-13.vars | 2 +-
> > tests/docker/dockerfiles/alpine.docker | 3 +-
> > tests/docker/dockerfiles/centos8.docker | 2 +-
> > .../dockerfiles/debian-amd64-cross.docker | 235 ++++++++---------
> > tests/docker/dockerfiles/debian-amd64.docker | 237
> > +++++++++---------
> > .../dockerfiles/debian-arm64-cross.docker | 233 ++++++++---------
> > .../dockerfiles/debian-armel-cross.docker | 231 ++++++++---------
> > .../dockerfiles/debian-armhf-cross.docker | 233 ++++++++---------
> > .../dockerfiles/debian-mips64el-cross.docker | 227 ++++++++---------
> > .../dockerfiles/debian-mipsel-cross.docker | 227 ++++++++---------
> > .../dockerfiles/debian-ppc64el-cross.docker | 231 ++++++++---------
> > .../dockerfiles/debian-s390x-cross.docker | 229 ++++++++---------
> > tests/docker/dockerfiles/fedora.docker | 230 ++++++++---------
> > tests/docker/dockerfiles/opensuse-leap.docker | 3 +-
> > tests/docker/dockerfiles/ubuntu2004.docker | 235 ++++++++---------
> > tests/lcitool/libvirt-ci | 2 +-
> > tests/lcitool/projects/qemu.yml | 1 +
> > tests/vm/freebsd | 3 +
> > 19 files changed, 1291 insertions(+), 1275 deletions(-)
> >
> >
> > This looks good to me. Why did the Linux containers need updating for
> > the FreeBSD update?
> >
> > Otherwise, the changes look good to my eye
> >
> > Reviewed-by: Warner Losh <imp@bsdimp.com>
>
>
> Because the CI configs are auto-generated. When refreshing them it generates
> them all. The intent was
> to update the FreeBSD configs, but when adding the dependency to
> tests/lcitool/projects/qemu.yml
> the FreeBSD configs are updated as well as the rest. Whatever OS's have a
> corresponding mapping
> in libvirt-ci are updated.
The POV of libvirt-ci, is that if the dependancy exists in any given
platform, we add it to the package list, so that we maximise the test
coverage across platforms. Surprisingly sndio was available in several
Linux distros.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2022-10-10 9:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 7:21 [PATCH v2] tests: Add sndio to the FreeBSD CI containers / VM Brad Smith
2022-10-07 8:09 ` Daniel P. Berrangé
2022-10-07 20:33 ` Warner Losh
2022-10-07 22:27 ` Brad Smith
2022-10-07 23:40 ` Warner Losh
2022-10-10 8:50 ` Daniel P. Berrangé [this message]
2022-10-25 14:36 ` Thomas Huth
2022-10-25 15:04 ` Brad Smith
2022-10-25 15:02 ` Brad Smith
2022-10-25 15:10 ` Thomas Huth
2022-10-25 15:23 ` Brad Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0Pc0NQQVrXDPgCH@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=bleal@redhat.com \
--cc=brad@comstyle.com \
--cc=emaste@freebsd.org \
--cc=f4bug@amsat.org \
--cc=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=lwhsu@freebsd.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).