From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B389EC4332F for ; Thu, 13 Oct 2022 22:50:05 +0000 (UTC) Received: from localhost ([::1]:34608 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oj71g-0000SG-A9 for qemu-devel@archiver.kernel.org; Thu, 13 Oct 2022 18:50:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oj6zX-0007wz-Bi for qemu-devel@nongnu.org; Thu, 13 Oct 2022 18:47:52 -0400 Received: from mga14.intel.com ([192.55.52.115]:7760) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oj6zS-00067u-RV for qemu-devel@nongnu.org; Thu, 13 Oct 2022 18:47:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665701266; x=1697237266; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=XWPEJtmvebi6hpe6OF9zkdH9SmY/ESzQOMMWzQmDqgI=; b=YDHaQLqYZD/VswOSaUsD3ElMUeV2Vw1M3GWnXXGgbqhnG9WLoRnAQ/l3 ZkWQ4CugjQMbnZ+UNPz7bXsAyvfLYTPikqyswJ2BrCuNxmWeT3JStrpkf V9b1QRSyLHqhEWsBpCYyW4a08+9NDHoGM+lKQFkX8b+koH2z50AfVaomD GraqUjTQoZ44Wl7lWBEa1wu6D5uarRNSoxKspxkulnzzwZBH2Ko0EH5/3 BgxkiKxZfq1gcKhtqWuTTONrHGIjUeSqLrOK9PurvusFP49etCCpEuk3a s6yMfOVgly+KNI8jlHxsjuy/LbKrA+EhroW5tvCMArLYgLH1sqPfGldft g==; X-IronPort-AV: E=McAfee;i="6500,9779,10499"; a="305215685" X-IronPort-AV: E=Sophos;i="5.95,182,1661842800"; d="scan'208";a="305215685" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2022 15:47:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10499"; a="769808039" X-IronPort-AV: E=Sophos;i="5.95,182,1661842800"; d="scan'208";a="769808039" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 13 Oct 2022 15:47:42 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 13 Oct 2022 15:47:42 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 13 Oct 2022 15:47:41 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 13 Oct 2022 15:47:41 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.43) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 13 Oct 2022 15:47:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UwaRnQLiasKHE5BPubdpEpiuazO3rFJ5RxVVyVAAkNJJ3uIJvrlzmK1Gk6RrRE+EkhUTa3mqOPJQpcBL1Tvnk77DmlCyfIbNYnMPQw9Ecqz798/KKM6eW+yIc0yzBPDJjphEpVPCvnlraZz6P8TMr2DGrj18X9Zs5c2/r/BOyyevSHiZXKgaXgeZ8aeSx21+4/YwXc34Vp5NXzhJZo4tgjbA8/sSPOZlzDkkKkRoP17bk50foV5kyCY4s5wcuip875z6Qy0nhojRLbn4KrK8U/jXE+pKJlvEUsxEzJigFzgIW2EvumkoNJC/ouNRyeB2eI7xtAyKWI/WT+PmlbGG1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bGiD9v0iZwGvrCctGVe30kF/GIacyE4K/CF3Hm1watY=; b=JDPx0Bzg2nWr17BvZwOeZCWH60SeQv0o1QZwivz7Nyp4eVRqYj0g/IOaaTHRv9k/c41gdO+0Q7mC2GqUH92IRqBfDWYPprjMxQuoilgXURiOrihXYDA+1kgw3L1Uh1MttnPS/kdIY0/H00E9FrhWibney/5LT/lkT2zdGa1OAnUEr3kaz9nrj1IbPorYJakG+eOmzCaGujUIoYAFmVoguhXctpGZghQozLvQTE3XRkxyWUuIf8VicsVKDzn+nlOeVSS1JNpOl4An6rKZKANb/Dgwc300tdsVp6fgREAVlIQpPS7odw0+87TNhDXqJQsW8fqNtLMrMdDUB5nWv1G/7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SA1PR11MB6733.namprd11.prod.outlook.com (2603:10b6:806:25c::17) by SA0PR11MB4766.namprd11.prod.outlook.com (2603:10b6:806:92::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 13 Oct 2022 22:47:40 +0000 Received: from SA1PR11MB6733.namprd11.prod.outlook.com ([fe80::6f83:c165:aa0c:efae]) by SA1PR11MB6733.namprd11.prod.outlook.com ([fe80::6f83:c165:aa0c:efae%8]) with mapi id 15.20.5723.026; Thu, 13 Oct 2022 22:47:39 +0000 Date: Thu, 13 Oct 2022 15:47:34 -0700 From: Ira Weiny To: Peter Maydell CC: Richard Henderson , Michael Tsirkin , Ben Widawsky , Jonathan Cameron , , Subject: Re: [RFC PATCH 1/6] qemu/bswap: Add const_le64() Message-ID: References: <20221010222944.3923556-1-ira.weiny@intel.com> <20221010222944.3923556-2-ira.weiny@intel.com> <05ed1f6a-0771-798c-408b-272fb57b4582@linaro.org> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: BY5PR04CA0023.namprd04.prod.outlook.com (2603:10b6:a03:1d0::33) To SA1PR11MB6733.namprd11.prod.outlook.com (2603:10b6:806:25c::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA1PR11MB6733:EE_|SA0PR11MB4766:EE_ X-MS-Office365-Filtering-Correlation-Id: 77ee92a5-f2bf-4607-795a-08daad6cee90 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eMa0t6+WQNUa4jlKG0pzqWDEidUH3jYsusSJtTh0qqzER9fSdc3W+X5mJgSSNy2gUks+rKjdG6uLdXd+NJwQ65N2tnaAFGJwD55eL4uOEq9n1X5YSgUu01y7BRSHv3u9c7A7sEqS218kFpZUmdDxAmeBCbquKiEjldoB7N9qNb9qDoTiPWzTWtqCU60J+iAQvgnJG2Hhhlykr12ETu8VBMdpwCvk8uAOkJdciCQOqnvHVW27gwsI5UWQndY+uFq+8+DaMv3h94eHdpNUtnpUPCqm8R85e6YTPLebBKVK12sH504a/YnxyRjkoivB3+U2nY4vdrYTNDZ3KBT8sESfllq4O66TSQtMHIHxv2XoE4bXsjslojkHI+4op6uEjQRz3ZdwPXPnnalDu/hN7y+gGDiAwPEW/AwfMIWDL8Z37g1tAaqMXkbie3q3cII4f4fjZCiAPWxenBp4q9BJeDfrhz09bCW7XUWhuhy83mHITyJypqjJ6U0go2pO1bigP6OBXo+pUpHALgHi/+d3JT/MpOSbtqj9gYWyQdx5LioKlLcFdof2wPBUuGCWpH3de/ENeP1Dk9F+5AcmfyMBwkw8lRURULfsig+jryOCdasHnI5AkeLaDpMOIUhk3JX7JCKoTq+lje1CTEBK62o8/+upbim11JsuXiPLRZRbvxRmFkeTHhZn23BzfdacuhThIaZ2Br5a8/rodID0fQWdFsJ9Ug== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA1PR11MB6733.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(7916004)(376002)(136003)(346002)(366004)(39860400002)(396003)(451199015)(478600001)(316002)(54906003)(6916009)(66946007)(6666004)(6486002)(4326008)(8676002)(66476007)(66556008)(6512007)(9686003)(8936002)(26005)(41300700001)(33716001)(44832011)(5660300002)(186003)(6506007)(2906002)(83380400001)(82960400001)(53546011)(38100700002)(86362001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1jLiyzfdDTYO+qVh/3nPuWifFiLpjCQeKvSe747Kcl1APdW3F3V8/NktlbSC?= =?us-ascii?Q?qOY05FgRGQB77SkuTwTy0b62GQfOOn8m+LETaw7DND4R24MX+GiGhVmweEvG?= =?us-ascii?Q?RI2j4G+2P6+k52Gpz9RaxQ3xTQK3XBPW6UywOsWi6HceGsWAS2x+jPmFzyRv?= =?us-ascii?Q?s7TvggN25K/WyhJbpbiD0/w6/yv7rdp4JW0tFZ4KGiOf33VRsJho41InwxzY?= =?us-ascii?Q?5cUpbi7D2nbeOoxTh9qQKFxj7g4NZ/LK2b32qUzDOYjSug31sckLXV4siseb?= =?us-ascii?Q?Tnm2NWNsfMFlTqt883IxMUZOc0roeAI+CNsSJZXLh9Dbs9vmQ7ZWIJ/H06JG?= =?us-ascii?Q?C6S6nyIK/XTn3vwhNLiD9otQntpXMJY504fV00Megxg0ak4QSf+JE7K1h+xb?= =?us-ascii?Q?/+WZMEigPF9lEREQnf4M63BKKn1RcocDDaMx7d1Da9Lm5ahmaDQhjFRmdign?= =?us-ascii?Q?w2Kc63pRm4kp8ON6DnUwHYEkHxVnvqjc1lNQ/6r9ziMVEwm28MXWvbECX7hc?= =?us-ascii?Q?rMnWaf+WMjwrMuW2a/2nYUVw+uF/TaOp1+iBu5/Zm25NT5xDSegwlQlEOC0V?= =?us-ascii?Q?RBPxCP8BWWFVuh+SgjCYs51wallOa5bQ+JHDr7TxyVEgVFgG9oVsbPIw8bef?= =?us-ascii?Q?IztO3BSO0I+6RBuU0sCvMhDWZGZGMW9MC0/QAgFpxPaoWeyFw1BsjkaZTdWn?= =?us-ascii?Q?QXwSH48i49SlORp6P+evMKF17gHrZRvoLy0yNNcohBoYGOkS+iPtvcvel2/M?= =?us-ascii?Q?HL9gwVMYGMrTcjCQSQ11ovP5NkzbYuLIfPfQPhgov9wm6yRtDq95hkRGb3d8?= =?us-ascii?Q?ciLqSALN79F86RSS717xB1zkiv8w9KdpOlAgBe4xuaydlfd3g5L6Q90ohtve?= =?us-ascii?Q?SBM4+uyFpjTiIPblu/YCVUVhy1vpw1OMt1nO8TNOLMX4+BBnQSnOzbHkjrM3?= =?us-ascii?Q?sWjY6oG7NimN6LihekHIWlqg8UZGbmIFjXV3cceHTpBdaScUpaNV8hU1706H?= =?us-ascii?Q?E3epGAcntDJqT85V/FB/kOg1vG6qQRFs/P+SMMpIOVTOTSLlw/NFElkSI+r4?= =?us-ascii?Q?QpOLU61S/C9inEdoOkwk9laDMToFiouE8uOMPHqZzi+h+txZtr2JPW2+uxU9?= =?us-ascii?Q?gWcSzcGrKCx3ZoDHoXrdt86Qx42rgNHmqpYV9YSEFBCTiNLkWrbO6IowzCaO?= =?us-ascii?Q?J+Gh5YhyHkOFepWQB0+umID4wl1Acdd7KAO8Epy9zU8Ju0Y5IGpWTTmA80ZY?= =?us-ascii?Q?3hWro6IIhrXl9MD5lQkt3BjkmSmdapDonj+yBweHoTlxQAG5NotnfK+7z6a5?= =?us-ascii?Q?sOf9KeM69B0DcIGd/faq2e9hoTWdw7YflpXbekWJc0GnSIjnuWAdKJP+6pRd?= =?us-ascii?Q?OcS1hXUG4JG7I93lXJtCHA2WDz5/1glX9N9kk/cZx1Vtnrtkcqr0V0RpcfS7?= =?us-ascii?Q?8dSP3QHrpbL9aZdIC53UKw8R/rNUzq0lgZFbMQVR/QcLWdRI2/CmnxSsVPpk?= =?us-ascii?Q?cV0633zmkwlgy/X8GZQRpbGT0ZFobvFYbZwjECXBjqjEHxo0LUPHzdhHnjNV?= =?us-ascii?Q?+odfwBFzh4spxTMRvMbJPl+2mWR/9nYGosbsCaIP?= X-MS-Exchange-CrossTenant-Network-Message-Id: 77ee92a5-f2bf-4607-795a-08daad6cee90 X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 22:47:39.8114 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: O9mUZCA6rnwls3EQp25+Vc/rDym4vBqHdrsaA8W5PJ8tEoD3B5c24+w6a6J9YVUQk0G6wZw+83WEmyQ9NjH3Cg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4766 X-OriginatorOrg: intel.com Received-SPF: pass client-ip=192.55.52.115; envelope-from=ira.weiny@intel.com; helo=mga14.intel.com X-Spam_score_int: -70 X-Spam_score: -7.1 X-Spam_bar: ------- X-Spam_report: (-7.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Oct 11, 2022 at 04:45:57PM +0100, Peter Maydell wrote: > On Tue, 11 Oct 2022 at 16:22, Richard Henderson > wrote: > > On 10/11/22 02:48, Peter Maydell wrote: > > > This is kind of a weird API, because: > > > * it only exists for little-endian, not big-endian > > > * we use it in exactly two files (linux-user/elfload.c and > > > hw/input/virtio-input-hid.c) > > > > > > which leaves me wondering if there's a better way of doing > > > it that I'm missing. But maybe it's just that we never filled > > > out the missing bits of the API surface because we haven't > > > needed them yet. Richard ? > > > > It's piecemeal because, as you note, very few places require a version of byte swapping > > that must be applicable to static data. I certainly don't want to completely fill this > > out and have most of it remain unused. > > Makes sense. In that case, other than ordering the definitions > 64-32-16, Done. > > Reviewed-by: Peter Maydell Thanks! Ira