From: Peter Xu <peterx@redhat.com>
To: "manish.mishra" <manish.mishra@nutanix.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
"Juan Quintela" <quintela@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Prerna Saxena" <prerna.saxena@nutanix.com>
Subject: Re: MultiFD and default channel out of order mapping on receive side.
Date: Thu, 20 Oct 2022 12:32:06 -0400 [thread overview]
Message-ID: <Y1F4BgFskXizW2za@x1n> (raw)
In-Reply-To: <4c1e4137-a686-427c-df3e-22f299a39478@nutanix.com>
On Thu, Oct 20, 2022 at 08:14:19PM +0530, manish.mishra wrote:
> I had one concern, during recover we do not send any magic. As of now we
do not support multifd with postcopy so it should be fine, we can do
explict checking for non-recovery case. But i remember from some
discussion in future there may be support for multiFD with postcopy or
have multiple postcopy preempt channels too, then proper handshake will
be required? So at some point we want to take that path? For now i agree
approach 1 will be good as suggested by Daniel it can be backported
easily to older qemu's too.
Yes for the long run I think we should provide a generic solution for all
the channels to be established for migration purpose.
Not to mention that as I replied previously to my original email, the trick
won't easily work with dest QEMU where we need further change to allow qemu
to accept new channels during loading of the VM.
Considering the complexity that it'll take just to resolve the prempt
channel ordering, I think maybe it's cleaner we just look for the long term
goal.
--
Peter Xu
next prev parent reply other threads:[~2022-10-20 20:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 19:53 MultiFD and default channel out of order mapping on receive side manish.mishra
2022-10-13 8:15 ` Daniel P. Berrangé
2022-10-13 8:56 ` manish.mishra
2022-10-17 7:36 ` manish.mishra
2022-10-17 11:38 ` Daniel P. Berrangé
2022-10-17 21:15 ` Peter Xu
2022-10-18 8:18 ` Daniel P. Berrangé
2022-10-18 14:51 ` Peter Xu
2022-10-18 21:00 ` Peter Xu
2022-10-20 14:44 ` manish.mishra
2022-10-20 16:32 ` Peter Xu [this message]
2022-10-20 22:07 ` Daniel P. Berrangé
2022-10-21 8:13 ` manish.mishra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1F4BgFskXizW2za@x1n \
--to=peterx@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=manish.mishra@nutanix.com \
--cc=prerna.saxena@nutanix.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).