From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 321D9FA3740 for ; Thu, 27 Oct 2022 13:19:13 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oo2i9-0005iP-8c; Thu, 27 Oct 2022 09:14:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo2i8-0005i0-8T for qemu-devel@nongnu.org; Thu, 27 Oct 2022 09:14:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo2i6-0005Nd-Mq for qemu-devel@nongnu.org; Thu, 27 Oct 2022 09:14:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666876453; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/o048q3cL1qzEGa36CUYekFyXmK/KD/5s7LbID3teUU=; b=Pq5w337tIn/0pjRqAfpYfNYO28JwFk4phJeQoz5me4ncjgnSS6k31JMLeymM5EQyP062fl HOqyCWtMNzsY2pdogCAEy5oL9BusJkQvWwItSnY6hQVXliQHj/JfPY5Oo/XwU6a/1qKHsp ACMINPzas1DxuaQKTcNSbfhTQio2sNQ= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-377-opp1anoAPJeFpOozRapcsw-1; Thu, 27 Oct 2022 09:14:10 -0400 X-MC-Unique: opp1anoAPJeFpOozRapcsw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A389D2A59540 for ; Thu, 27 Oct 2022 13:14:09 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.37]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1BC892166B2B; Thu, 27 Oct 2022 13:14:08 +0000 (UTC) Date: Thu, 27 Oct 2022 14:14:06 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Michal =?utf-8?B?UHLDrXZvem7DrWs=?= Cc: qemu-devel@nongnu.org Subject: Re: [PATCH v2] seccomp: Get actual errno value from failed seccomp functions Message-ID: References: <80c86614e3b21dda074b81fe9c3866fdbbb7420e.1666769319.git.mprivozn@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.7 (2022-08-07) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.515, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Sender: "Qemu-devel" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Oct 27, 2022 at 02:55:02PM +0200, Michal Prívozník wrote: > On 10/26/22 14:33, Daniel P. Berrangé wrote: > > On Wed, Oct 26, 2022 at 09:30:24AM +0200, Michal Privoznik wrote: > >> Upon failure, a libseccomp API returns actual errno value very > >> rarely. Fortunately, after its commit 34bf78ab (contained in > >> 2.5.0 release), the SCMP_FLTATR_API_SYSRAWRC attribute can be set > >> which makes subsequent APIs return true errno on failure. > >> > >> This is especially critical when seccomp_load() fails, because > >> generic -ECANCELED says nothing. > >> > >> Signed-off-by: Michal Privoznik > >> Reviewed-by: Philippe Mathieu-Daudé > >> --- > >> > >> v2 of: > >> > >> https://lists.gnu.org/archive/html/qemu-devel/2022-10/msg04509.html > >> > >> diff to v1: > >> - added comment when setting SYSRAWRC attribute per Philippe's > >> suggestion > >> > >> meson.build | 9 +++++++++ > >> softmmu/qemu-seccomp.c | 13 +++++++++++++ > >> 2 files changed, 22 insertions(+) > > > > Reviewed-by: Daniel P. Berrangé > > Thank you. Can somebody merge this please? I don't have commit access. I'm seccomp subsystem maintainer and have it queued. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|