qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, Hanna Reitz <hreitz@redhat.com>,
	nsoffer@redhat.com, qemu-block@nongnu.org,
	Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH v2 2/2] file-posix: add statx(STATX_DIOALIGN) support
Date: Fri, 11 Nov 2022 12:22:20 +0100	[thread overview]
Message-ID: <Y24wbBLXEPBs9H4e@redhat.com> (raw)
In-Reply-To: <20221103183609.363027-3-stefanha@redhat.com>

Am 03.11.2022 um 19:36 hat Stefan Hajnoczi geschrieben:
> Linux v6.1 commit 825cf206ed51 ("statx: add direct I/O alignment
> information") added an interface to fetch O_DIRECT alignment values for
> block devices and file systems.
> 
> Prefer STATX_DIOALIGN to older interfaces and probing, but keep them as
> fallbacks in case STATX_DIOALIGN cannot provide the information.
> 
> Testing shows the status of STATX_DIOALIGN support in Linux 6.1-rc3
> appears to be:
> - btrfs: no
> - ext4: yes
> - XFS: yes
> - NVMe block devices: yes
> - dm-crypt: yes
> 
> Cc: Eric Biggers <ebiggers@google.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

I think it's worth noting in the commit message that this essentially
disables patch 1 again on Linux 6.1 because it doesn't even use the code
any more that patch 1 modified to work around the dm-crypt bug.

This is only okay because we think that the final 6.1 release is going
to have the bug fixed, and it's also the first version to support
STATX_DIOALIGN, so you won't have both STATX_DIOALIGN and the bug in a
stable kernel.

Kevin



      reply	other threads:[~2022-11-11 11:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-03 18:36 [PATCH v2 0/2] file-posix: alignment probing improvements Stefan Hajnoczi
2022-11-03 18:36 ` [PATCH v2 1/2] file-posix: fix Linux alignment probing when EIO is returned Stefan Hajnoczi
2022-11-11 11:08   ` Kevin Wolf
2022-11-03 18:36 ` [PATCH v2 2/2] file-posix: add statx(STATX_DIOALIGN) support Stefan Hajnoczi
2022-11-11 11:22   ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y24wbBLXEPBs9H4e@redhat.com \
    --to=kwolf@redhat.com \
    --cc=ebiggers@google.com \
    --cc=hreitz@redhat.com \
    --cc=nsoffer@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).