From: Peter Xu <peterx@redhat.com>
To: Leonardo Bras <leobras@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
qemu-devel@nongnu.org, Li Xiaohui <xiaohli@redhat.com>
Subject: Re: [PATCH v1 1/1] migration: Fix yank on postcopy multifd crashing guest after migration
Date: Thu, 24 Nov 2022 11:04:42 -0500 [thread overview]
Message-ID: <Y3+WGof3MQtaCYdS@x1n> (raw)
In-Reply-To: <20221109055629.789795-1-leobras@redhat.com>
On Wed, Nov 09, 2022 at 02:56:29AM -0300, Leonardo Bras wrote:
> diff --git a/migration/savevm.c b/migration/savevm.c
> index a0cdb714f7..250caff7f4 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -1889,6 +1889,8 @@ static void *postcopy_ram_listen_thread(void *opaque)
> exit(EXIT_FAILURE);
> }
>
> + migration_load_cleanup();
It's a bit weird to call multifd-load-clean in a listen phase..
How about moving it right above
trace_process_incoming_migration_co_postcopy_end_main()? Then the new
helper can also be static.
> +
> migrate_set_state(&mis->state, MIGRATION_STATUS_POSTCOPY_ACTIVE,
> MIGRATION_STATUS_COMPLETED);
> /*
> --
> 2.38.1
>
--
Peter Xu
next prev parent reply other threads:[~2022-11-24 16:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 5:56 [PATCH v1 1/1] migration: Fix yank on postcopy multifd crashing guest after migration Leonardo Bras
2022-11-09 13:31 ` Dr. David Alan Gilbert
2022-11-09 16:59 ` Leonardo Bras Soares Passos
2022-11-10 13:47 ` Juan Quintela
2022-11-15 2:32 ` Leonardo Bras Soares Passos
2022-11-24 16:04 ` Peter Xu [this message]
2022-11-29 20:28 ` Leonardo Bras Soares Passos
2022-11-29 20:50 ` Peter Xu
2023-02-09 4:14 ` Leonardo Brás
2023-02-09 14:22 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3+WGof3MQtaCYdS@x1n \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=leobras@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=xiaohli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).