Re: [PATCH] multifd: Updated QAPI format for 'migrate' qemu monitor command

["Daniel P. Berrangé" <berrange@redhat.com>]

On Wed, Nov 23, 2022 at 01:35:22AM +0530, Het Gala wrote:
> 
> On 21/11/22 6:10 pm, Juan Quintela wrote:
> > Het Gala<het.gala@nutanix.com>  wrote:
> > > To prevent double data encoding of uris, instead of passing transport
> > > mechanisms, host address and port all together in form of a single string
> > > and writing different parsing functions, we intend the user to explicitly
> > > mention most of the parameters through the medium of qmp command itself.
> > Hi
> > 
> > 1st of all, I can't see how this is 7.1 material, I guess we need to
> > move it to 8.0.
> > 
> > Thankyou for informing. I will change it to 8.0
> > > +##
> > > +# @MigrateTransport:
> > > +#
> > > +# The supported communication transport mechanisms for migration
> > > +#
> > > +# @socket: Supported communication type between two devices for migration.
> > > +#          Socket is able to cover all of 'tcp', 'unix', 'vsock' and
> > > +#          'fd' already
> > > +#
> > > +# @exec: Supported communication type to redirect migration stream into file.
> > > +#
> > > +# Since 7.1
> > > +##
> > > +{ 'enum': 'MigrateTransport',
> > > +  'data': ['socket', 'exec'] }
> > I haven't looked too much into this, but as Danield told in the past, I
> > can see where the rdma falls into this scheme.  I guess it is going to
> > be its own, but who knows.
> So do you mean, 'data' : ['socket', 'exec', 'rdma'] ? or it will be
> separately represented

Yes, you'll need an rdma entry there.  If you follow the patch split
I suggested in the other mail, you'll naturally have to represent
'rdma' in the very first patch, as you introduce the new syntax
for addresses and parse the existing URIs to map onto the new
address struct.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|