From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Marc Hartmayer <mhartmay@linux.ibm.com>
Cc: qemu-devel@nongnu.org, qemu-s390x <qemu-s390x@nongnu.org>,
virtio-fs@redhat.com, Stefan Hajnoczi <stefanha@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Stefan Liebler <stli@linux.ibm.com>
Subject: Re: [PATCH] virtiofsd: Add `sigreturn` to the seccomp whitelist
Date: Tue, 29 Nov 2022 09:42:21 +0000 [thread overview]
Message-ID: <Y4XT/ZxuyU7F5h1n@work-vm> (raw)
In-Reply-To: <87wn7ef6cm.fsf@linux.ibm.com>
* Marc Hartmayer (mhartmay@linux.ibm.com) wrote:
> "Dr. David Alan Gilbert" <dgilbert@redhat.com> writes:
>
> > * Marc Hartmayer (mhartmay@linux.ibm.com) wrote:
> >> The virtiofsd currently crashes on s390x. This is because of a
> >> `sigreturn` system call. See audit log below:
> >>
> >> type=SECCOMP msg=audit(1669382477.611:459): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=system_u:system_r:virtd_t:s0-s0:c0.c1023 pid=6649 comm="virtiofsd" exe="/usr/libexec/virtiofsd" sig=31 arch=80000016 syscall=119 compat=0 ip=0x3fff15f748a code=0x80000000AUID="unset" UID="root" GID="root" ARCH=s390x SYSCALL=sigreturn
> >
> > I'm curious; doesn't that mean that some signal is being delivered and
> > you're returning? Which one?
>
> code=0x80000000 means that the seccomp action SECCOMP_RET_KILL_PROCESS
> is taken => process is killed by a SIGSYS signal (31) [1].
>
> At least, that’s my understanding of this log message.
>
> [1] https://man7.org/linux/man-pages/man2/seccomp.2.html
But isn't that the fallout rather than the cause ? i.e. seccomp
is sending a SIGSYS because the process used sigreturn, my question
is why did the process call sigreturn in the first place - it must
have received a signal to return from?
Dave
> […snip…]
>
> > --
> > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
> >
> --
> Kind regards / Beste Grüße
> Marc Hartmayer
>
> IBM Deutschland Research & Development GmbH
> Vorsitzender des Aufsichtsrats: Gregor Pillen
> Geschäftsführung: David Faller
> Sitz der Gesellschaft: Böblingen
> Registergericht: Amtsgericht Stuttgart, HRB 243294
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2022-11-29 9:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 14:39 [PATCH] virtiofsd: Add `sigreturn` to the seccomp whitelist Marc Hartmayer
2022-11-25 16:32 ` [Virtio-fs] " German Maglione
2022-11-28 6:18 ` Christian Borntraeger
2022-11-28 9:00 ` Marc Hartmayer
2022-11-28 10:17 ` German Maglione
2022-12-01 9:44 ` Marc Hartmayer
2022-11-25 20:50 ` Stefan Hajnoczi
2022-11-28 18:47 ` Dr. David Alan Gilbert
2022-11-29 9:38 ` Marc Hartmayer
2022-11-29 9:42 ` Dr. David Alan Gilbert [this message]
2022-11-29 9:52 ` Christian Borntraeger
2022-11-29 9:57 ` Christian Borntraeger
2022-11-29 10:16 ` Dr. David Alan Gilbert
2022-11-29 12:04 ` Stefan Hajnoczi
2022-11-29 10:16 ` Marc Hartmayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4XT/ZxuyU7F5h1n@work-vm \
--to=dgilbert@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=mhartmay@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=stefanha@redhat.com \
--cc=stli@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).