From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, kraxel@redhat.com, dgilbert@redhat.com
Subject: Re: [PATCH 3/9] ui: Drop disabled code for SPICE_CHANNEL_WEBDAV
Date: Thu, 1 Dec 2022 14:34:57 +0000 [thread overview]
Message-ID: <Y4i7kZCetDvFYnCp@redhat.com> (raw)
In-Reply-To: <87pmd3fgcu.fsf@pond.sub.org>
On Thu, Dec 01, 2022 at 01:39:13PM +0100, Markus Armbruster wrote:
> Daniel P. Berrangé <berrange@redhat.com> writes:
>
> > On Thu, Dec 01, 2022 at 07:13:05AM +0100, Markus Armbruster wrote:
> >> HMP "info spice" has a bit of code to show channel type
> >> SPICE_CHANNEL_WEBDAV as "webdav", disabled since commit 7c6044a94e
> >> "hmp: info spice: take out webdav" (v2.3.0), because it compiles only
> >> with Spice versions 0.12.7 and later. Our minimum version is 0.12.5.
> >
> > Last version bump was 4 years ago
> >
> > commit 1b63665c2c0e0d52735e0dd5217f109fe0dd2322
> > Author: Marc-André Lureau <marcandre.lureau@redhat.com>
> > Date: Wed Nov 28 19:59:32 2018 +0400
> >
> > configure: bump spice-server required version to 0.12.5
> >
> > ...snip....
> >
> > According to repology, all the distros that are build target platforms
> > for QEMU include it:
> >
> > RHEL-7: 0.14.0
> > Debian (Stretch): 0.12.8
> > Debian (Jessie): 0.12.5
> > FreeBSD (ports): 0.14.0
> > OpenSUSE Leap 15: 0.14.0
> > Ubuntu (Xenial): 0.12.6
> >
> > We moved on from Debian and RHEL since then
> >
> > Debian 11: 0.14.3
> > RHEL-8: 0.14.2
> > FreeBSD (ports): 0.14.4
> > Fedora 35: 0.14.0
> > Ubuntu 20.04: 0.14.0
> > OpenSUSE Leap 15.3: 0.14.3
> >
> > IOW, we can bump to 0.14.0, and then revert the
> > webdav conditional commit.
>
> We need to bump spice-protocol, actually.
Opps, I'm getting mixed up. The commit I mentioned was spice-server,
but the new versions I've listed just were indeed spice-protocol
> Would you like me to bump spice-server as well? To which version?
Yes, might as well, the spice-server versions are slightly different:
Debian 11: 0.14.3
RHEL-8: 0.14.3
FreeBSD (ports): 0.15.0
Fedora 35: 0.15.0
Ubuntu 20.04: 0.14.2
OpenSUSE Leap 15.3: 0.14.3
I think we might as well pick 0.14.0 for both protocol and server.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2022-12-01 14:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 6:13 [PATCH 0/9] ui: Move and clean up monitor command code Markus Armbruster
2022-12-01 6:13 ` [PATCH 1/9] ui: Check numeric part of expire_password argument @time properly Markus Armbruster
2022-12-01 8:13 ` Daniel P. Berrangé
2022-12-01 6:13 ` [PATCH 2/9] ui: Fix silent truncation of numeric keys in HMP sendkey Markus Armbruster
2022-12-01 8:14 ` Daniel P. Berrangé
2022-12-01 6:13 ` [PATCH 3/9] ui: Drop disabled code for SPICE_CHANNEL_WEBDAV Markus Armbruster
2022-12-01 8:49 ` Daniel P. Berrangé
2022-12-01 10:25 ` Markus Armbruster
2022-12-01 12:39 ` Markus Armbruster
2022-12-01 14:34 ` Daniel P. Berrangé [this message]
2022-12-01 15:49 ` Markus Armbruster
2022-12-01 18:34 ` Daniel P. Berrangé
2022-12-02 6:52 ` Markus Armbruster
2022-12-01 6:13 ` [PATCH 4/9] ui: Clean up a few things checkpatch.pl would flag later on Markus Armbruster
2022-12-01 8:50 ` Daniel P. Berrangé
2022-12-01 6:13 ` [PATCH 5/9] ui: Move QMP commands from monitor to new ui/ui-qmp-cmds.c Markus Armbruster
2022-12-01 6:38 ` Markus Armbruster
2022-12-11 16:48 ` Markus Armbruster
2022-12-01 8:51 ` Daniel P. Berrangé
2022-12-01 6:13 ` [PATCH 6/9] ui: Move HMP commands from monitor to new ui/ui-hmp-cmds.c Markus Armbruster
2022-12-01 7:14 ` Philippe Mathieu-Daudé
2022-12-01 10:26 ` Markus Armbruster
2022-12-01 8:53 ` Daniel P. Berrangé
2022-12-01 6:13 ` [PATCH 7/9] ui: Improve "change vnc" error reporting Markus Armbruster
2022-12-01 8:56 ` Daniel P. Berrangé
2022-12-01 10:27 ` Markus Armbruster
2022-12-01 6:13 ` [PATCH 8/9] ui: Factor out hmp_change_vnc(), and move to ui/ui-hmp-cmds.c Markus Armbruster
2022-12-01 8:57 ` Daniel P. Berrangé
2022-12-01 6:13 ` [PATCH 9/9] ui: Reduce nesting in hmp_change_vnc() slightly Markus Armbruster
2022-12-01 7:19 ` Philippe Mathieu-Daudé
2022-12-01 8:58 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4i7kZCetDvFYnCp@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).