From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93927C43217 for ; Thu, 1 Dec 2022 18:35:10 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0oOB-0003g9-Pa; Thu, 01 Dec 2022 13:34:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0oO3-0003f0-JK for qemu-devel@nongnu.org; Thu, 01 Dec 2022 13:34:23 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0oO1-0000i1-LQ for qemu-devel@nongnu.org; Thu, 01 Dec 2022 13:34:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669919656; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m1y9wrOtCFswNLe9qgYbZR8RCPA8Kuck0aMMU8rl+gI=; b=UReLQ+qWQluuQjFQJfkGAWoCl07T2AKF682/581OhbGm8xzLYdeBEcs9XC/r14h1xQlcfM vxi7z5eBDgKb2MoqcuDPYnT06VxYibzsW31c4/XmJuNQocNlAQptjxLHnrYV8KM/W6qszi U0K3HA4tVzygdXM9RCII9BDipaOnv7I= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-332-m-uaFNq-N4CzqBu7U-YD7Q-1; Thu, 01 Dec 2022 13:34:14 -0500 X-MC-Unique: m-uaFNq-N4CzqBu7U-YD7Q-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 54B31811E7A for ; Thu, 1 Dec 2022 18:34:14 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.179]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7F970205FA83; Thu, 1 Dec 2022 18:34:12 +0000 (UTC) Date: Thu, 1 Dec 2022 18:34:07 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Markus Armbruster Cc: qemu-devel@nongnu.org, kraxel@redhat.com, dgilbert@redhat.com, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Subject: Re: [PATCH 3/9] ui: Drop disabled code for SPICE_CHANNEL_WEBDAV Message-ID: References: <20221201061311.3619052-1-armbru@redhat.com> <20221201061311.3619052-4-armbru@redhat.com> <87pmd3fgcu.fsf@pond.sub.org> <87wn7bdsze.fsf@pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87wn7bdsze.fsf@pond.sub.org> User-Agent: Mutt/2.2.7 (2022-08-07) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Dec 01, 2022 at 04:49:25PM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Thu, Dec 01, 2022 at 01:39:13PM +0100, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > >> > On Thu, Dec 01, 2022 at 07:13:05AM +0100, Markus Armbruster wrote: > >> >> HMP "info spice" has a bit of code to show channel type > >> >> SPICE_CHANNEL_WEBDAV as "webdav", disabled since commit 7c6044a94e > >> >> "hmp: info spice: take out webdav" (v2.3.0), because it compiles only > >> >> with Spice versions 0.12.7 and later. Our minimum version is 0.12.5. > >> > > >> > Last version bump was 4 years ago > >> > > >> > commit 1b63665c2c0e0d52735e0dd5217f109fe0dd2322 > >> > Author: Marc-André Lureau > >> > Date: Wed Nov 28 19:59:32 2018 +0400 > >> > > >> > configure: bump spice-server required version to 0.12.5 > >> > > >> > ...snip.... > >> > > >> > According to repology, all the distros that are build target platforms > >> > for QEMU include it: > >> > > >> > RHEL-7: 0.14.0 > >> > Debian (Stretch): 0.12.8 > >> > Debian (Jessie): 0.12.5 > >> > FreeBSD (ports): 0.14.0 > >> > OpenSUSE Leap 15: 0.14.0 > >> > Ubuntu (Xenial): 0.12.6 > >> > > >> > We moved on from Debian and RHEL since then > >> > > >> > Debian 11: 0.14.3 > >> > RHEL-8: 0.14.2 > >> > FreeBSD (ports): 0.14.4 > >> > Fedora 35: 0.14.0 > >> > Ubuntu 20.04: 0.14.0 > >> > OpenSUSE Leap 15.3: 0.14.3 > >> > > >> > IOW, we can bump to 0.14.0, and then revert the > >> > webdav conditional commit. > >> > >> We need to bump spice-protocol, actually. > > > > Opps, I'm getting mixed up. The commit I mentioned was spice-server, > > but the new versions I've listed just were indeed spice-protocol > > > >> Would you like me to bump spice-server as well? To which version? > > > > Yes, might as well, the spice-server versions are slightly different: > > > > Debian 11: 0.14.3 > > RHEL-8: 0.14.3 > > FreeBSD (ports): 0.15.0 > > Fedora 35: 0.15.0 > > Ubuntu 20.04: 0.14.2 > > OpenSUSE Leap 15.3: 0.14.3 > > > > I think we might as well pick 0.14.0 for both protocol and server. > > Makes sense, but it leads to another question. > > I found obvious version checks for spice-protocol, and dropped the > outmoded ones, namely > > #if CHECK_SPICE_PROTOCOL_VERSION(0, 14, 0) > > For spice-server, I see a bunch of SPICE_INTERFACE_FOO_{MAJOR,MINOR} we > check, and which ones become outmoded is not obvious to me. Help? Ignore all the interface ones. For the server, the check to look for is against SPICE_SERVER_VERSION chardev/spice.c:#if SPICE_SERVER_VERSION >= 0x000c06 chardev/spice.c:#if SPICE_SERVER_VERSION < 0x000e02 hw/display/qxl.c:#if SPICE_SERVER_VERSION >= 0x000c06 && SPICE_SERVER_VERSION < 0x000e02 hw/display/qxl.c:#if SPICE_SERVER_VERSION >= 0x000c06 /* release 0.12.6 */ hw/display/qxl.c:#if SPICE_SERVER_VERSION >= 0x000e02 /* release 0.14.2 */ hw/display/qxl.c:#if SPICE_SERVER_VERSION >= 0x000c06 /* release 0.12.6 */ hw/display/qxl.h:#if SPICE_SERVER_VERSION >= 0x000c06 /* release 0.12.6 */ include/ui/qemu-spice.h:#if !defined(SPICE_SERVER_VERSION) || (SPICE_SERVER_VERSION < 0xc06) include/ui/qemu-spice.h:#if defined(SPICE_SERVER_VERSION) && (SPICE_SERVER_VERSION >= 0x000f00) include/ui/spice-display.h:# if SPICE_SERVER_VERSION >= 0x000d01 /* release 0.13.1 */ ui/spice-display.c:#if SPICE_SERVER_VERSION >= 0x000e04 /* release 0.14.4 */ ui/spice-display.c:#if SPICE_SERVER_VERSION >= 0x000e02 /* release 0.14.2 */ A fair few of those will be obsolete With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|