From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2DD52C4167B for ; Fri, 16 Dec 2022 10:28:05 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p67w4-0003VA-UB; Fri, 16 Dec 2022 05:27:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p67w3-0003V0-2R for qemu-devel@nongnu.org; Fri, 16 Dec 2022 05:27:23 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p67w0-0007AL-Qv for qemu-devel@nongnu.org; Fri, 16 Dec 2022 05:27:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671186438; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=od9tr1CU/+0NA1+NEyC4BrrzpOKwh77yAvR7vdFGdAk=; b=hsxg+6MdnmVDj06myVWHVllVMA8YyxUnNd36r50dhK2+tJH18/tUvUeA23XIsXzqQVQnhL zVo4npM5kMp1ot5w8K5q0hbA/NQmK3ZNqrrHRqVSPowcVKedafAW+Brzaf0q+iZhZZWzfJ 5dAr8Pp2yPVVmHDEV0KIIRgEnyKsmbo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-492-XNlhjtsaOauUfJnIy55-_g-1; Fri, 16 Dec 2022 05:27:15 -0500 X-MC-Unique: XNlhjtsaOauUfJnIy55-_g-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D9C6C811E6E; Fri, 16 Dec 2022 10:27:14 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.128]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DB081140E949; Fri, 16 Dec 2022 10:27:13 +0000 (UTC) Date: Fri, 16 Dec 2022 10:27:11 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Stefan Berger Cc: jejb@linux.ibm.com, qemu-devel@nongnu.org, Markus Armbruster Subject: Re: [PATCH 2/2] tpm: add backend for mssim Message-ID: References: <20221215180125.24632-3-jejb@linux.ibm.com> <6fd1144d09777ddcdb7a1a1ba58cbbec345da9ef.camel@linux.ibm.com> <77bc5a11fcb7b06deba1c54b1ef2de28e0c53fb1.camel@linux.ibm.com> <10fbda0f-7c8a-3819-fb22-34a9249ac138@linux.ibm.com> <9fac7d95-d891-413f-93f1-18324c7943ea@linux.ibm.com> <29e99f54-d5e8-b18d-08a6-d24435032272@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <29e99f54-d5e8-b18d-08a6-d24435032272@linux.ibm.com> User-Agent: Mutt/2.2.7 (2022-08-07) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Dec 15, 2022 at 03:53:43PM -0500, Stefan Berger wrote: > > > On 12/15/22 15:30, James Bottomley wrote: > > On Thu, 2022-12-15 at 15:22 -0500, Stefan Berger wrote: > > > On 12/15/22 15:07, James Bottomley wrote: > > [...] > > > > don't really have much interest in the migration use case, but I > > > > knew it should work like the passthrough case, so that's what I > > > > tested. > > > > > > I think your device needs to block migrations since it doesn't handle > > > all migration scenarios correctly. > > > > Passthrough doesn't block migrations either, presumably because it can > > also be made to work if you know what you're doing. I might not be > > Don't compare it to passthrough, compare it to swtpm. It should > have at least the same features as swtpm or be better, otherwise > I don't see why we need to have the backend device in the upstream > repo. James has explained multiple times that mssim is a beneficial thing to support, given that it is the reference implementation of TPM2. Requiring the same or greater features than swtpm is an unreasonable thing to demand. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|