From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 360A9C4332F for ; Mon, 19 Dec 2022 10:57:38 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7DpW-0000bB-4U; Mon, 19 Dec 2022 05:57:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7DpT-0000aj-Rn for qemu-devel@nongnu.org; Mon, 19 Dec 2022 05:57:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7DpS-00058c-8D for qemu-devel@nongnu.org; Mon, 19 Dec 2022 05:57:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671447425; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=pz6P4nnUh6+wujqTL8XjPINvAzSjBRYSGypnSqUkBJU=; b=HAggkvMMqoNCYpQQ7KLF7QShYUUQLD2Dg9pRRcxYKFzDUtTuXhEjVVC9xaVMSo96AZi2eb 1L4g9sFzF6OpK3dyoDt+way0F8YiwjZdesoOe1QW/PtH9DK9e6BvGiO/F4hKcSDnQQ6UDV jfE1dHafuhPZJTnvMInoTiWoM2TM76s= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-490-jp9FAuAmMk2EfVWlVwP-yg-1; Mon, 19 Dec 2022 05:57:01 -0500 X-MC-Unique: jp9FAuAmMk2EfVWlVwP-yg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 49DEA803494; Mon, 19 Dec 2022 10:57:01 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.198]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3309B39D7C; Mon, 19 Dec 2022 10:57:00 +0000 (UTC) Date: Mon, 19 Dec 2022 10:56:57 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Shreesh Adiga <16567adigashreesh@gmail.com> Cc: qemu-devel@nongnu.org, jasowang@redhat.com, andrew@daynix.com, yuri.benditovich@daynix.com Subject: Re: [PATCH] ebpf: fix compatibility with libbpf 1.0+ Message-ID: References: <20221218143927.597975-1-16567adigashreesh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221218143927.597975-1-16567adigashreesh@gmail.com> User-Agent: Mutt/2.2.7 (2022-08-07) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Sun, Dec 18, 2022 at 08:09:27PM +0530, Shreesh Adiga wrote: > The current implementation fails to load on a system with > libbpf 1.0 and reports that legacy map definitions in 'maps' > section are not supported by libbpf v1.0+. This commit updates > the Makefile to add BTF (-g flag) and appropriately updates > the maps in rss.bpf.c and update the skeleton file in repo. Can you split this into two pieces - one updating the build system for new compiler usage, and one updating the program to remove the legacy map defs. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|