From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B541CC4332F for ; Tue, 20 Dec 2022 10:00:01 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7YjH-00079L-SP; Tue, 20 Dec 2022 04:16:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7YjD-00078S-CF for qemu-devel@nongnu.org; Tue, 20 Dec 2022 04:16:03 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7YjB-0007p2-8q for qemu-devel@nongnu.org; Tue, 20 Dec 2022 04:16:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671527760; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=floff8oR6QS9ZHtoBiUa9CE+NjVUB3uyU0WfFAOB77A=; b=YoeMdYx+RO8jFGgFid3jELNVEutE90GHVpLr/HxuvFtC1oTF9wud+XVTJhVkbYQrWjCgv9 9rCUEhrNLswr9UGmW/e80zRO6k+b2Tf0arfBS3xfXkee25VJONGBZkzOdUJ8UNha1Xd80G TLopghd5LjEjUZTlsYS8HK5pkSpM96Q= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-27-np3OkzrxPmaStjZ1xZHAWw-1; Tue, 20 Dec 2022 04:15:56 -0500 X-MC-Unique: np3OkzrxPmaStjZ1xZHAWw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7816F802D1A; Tue, 20 Dec 2022 09:15:56 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.87]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7EC142026D4B; Tue, 20 Dec 2022 09:15:55 +0000 (UTC) Date: Tue, 20 Dec 2022 09:15:53 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Markus Armbruster Cc: qemu-devel@nongnu.org, kraxel@redhat.com, dgilbert@redhat.com, philmd@linaro.org Subject: Re: [PATCH v3 16/18] ui: Split hmp_mouse_set() and move the HMP part to ui/ Message-ID: References: <20221220090645.2844881-1-armbru@redhat.com> <20221220090645.2844881-17-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221220090645.2844881-17-armbru@redhat.com> User-Agent: Mutt/2.2.7 (2022-08-07) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Dec 20, 2022 at 10:06:43AM +0100, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > include/monitor/hmp.h | 1 + > include/ui/console.h | 2 +- > monitor/misc.c | 1 - > ui/input.c | 5 +---- > ui/ui-hmp-cmds.c | 8 ++++++++ > 5 files changed, 11 insertions(+), 6 deletions(-) > > -void hmp_mouse_set(Monitor *mon, const QDict *qdict) > +void qemu_mouse_set(int index, Error **err) This is adding a Error parameter, nit s/err/errp/ > { > QemuInputHandlerState *s; > - int index = qdict_get_int(qdict, "index"); > int found = 0; > > QTAILQ_FOREACH(s, &handlers, node) { But not changing either error_report() call to error_setg(), so the errp is unused. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|