From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31221C54EBD for ; Thu, 12 Jan 2023 09:55:19 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pFuHn-0001a1-Ft; Thu, 12 Jan 2023 04:54:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFuHm-0001Wd-4J for qemu-devel@nongnu.org; Thu, 12 Jan 2023 04:54:14 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFuHj-0003VK-Kx for qemu-devel@nongnu.org; Thu, 12 Jan 2023 04:54:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673517250; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/kXhV1FHIS7TrlfoLlybtuLtx2OwSLudWxpl3Q1Ya28=; b=JEq2Zrg9nqr94LaJMX1lte0iit1l+eG3qDXBg4Wss5IT9fv+CaPJJPGL9Ii96jX6gr2Cdt e9Yf/5GKZ6ocAuZUDEkDoVnwKzj3i0NkHBEepMLbkfNbfgmT/mv7z/F7U6+dpgS2s9OF9r niZVTwaRe33hT9+iXYRj9crujtdnWdQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-82-4YSCAfVgMymjwmkveCBMDw-1; Thu, 12 Jan 2023 04:54:07 -0500 X-MC-Unique: 4YSCAfVgMymjwmkveCBMDw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 08E3C85A588; Thu, 12 Jan 2023 09:54:07 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.222]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D2AFD40C2064; Thu, 12 Jan 2023 09:54:05 +0000 (UTC) Date: Thu, 12 Jan 2023 09:54:03 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: Stefan Berger , qemu-devel@nongnu.org, marcandre.lureau@redhat.com, peter.maydell@linaro.org Subject: Re: [PATCH] tests/qtest: Poll on waitpid() for a while before sending SIGKILL Message-ID: References: <20230111223018.3965423-1-stefanb@linux.ibm.com> <7799fdd7-755e-11c5-fe10-3f4afc00376b@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7799fdd7-755e-11c5-fe10-3f4afc00376b@linaro.org> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Jan 12, 2023 at 10:18:01AM +0100, Philippe Mathieu-Daudé wrote: > On 11/1/23 23:30, Stefan Berger wrote: > > To prevent getting stuck on waitpid() in case the target process does > > not terminate on SIGTERM, poll on waitpid() for 10s and if the target > > process has not changed state until then send a SIGKILL to it. > > > > Signed-off-by: Stefan Berger > > --- > > tests/qtest/libqtest.c | 18 +++++++++++++++++- > > 1 file changed, 17 insertions(+), 1 deletion(-) > > > > diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c > > index 2fbc3b88f3..362b1f724f 100644 > > --- a/tests/qtest/libqtest.c > > +++ b/tests/qtest/libqtest.c > > @@ -202,8 +202,24 @@ void qtest_wait_qemu(QTestState *s) > > { > > #ifndef _WIN32 > > pid_t pid; > > + uint64_t end; > > + > > + /* poll for 10s until sending SIGKILL */ > > + end = g_get_monotonic_time() + 10 * G_TIME_SPAN_SECOND; > > Maybe we could use getenv() to allow tuning / using different value? I'd rather we picked a value large enough that it will work reliably out of the box for all scenarios with no magic env required. We're just trying to prevent infinite waits if something unexpected happens. We don't need to use an aggressively short value, as most users will never hit this scenario. I think 30 seconds is large enough to be reliable but we could easily go higher to 60/120 if we want to be really really sure. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|