From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org,
Havard Skinnemoen <hskinnemoen@google.com>,
Alistair Francis <alistair@alistair23.me>,
Peter Maydell <peter.maydell@linaro.org>,
Eduardo Habkost <eduardo@habkost.net>,
Tyrone Ting <kfting@nuvoton.com>
Subject: Re: [PATCH 14/14] hw/timer/xilinx_timer: Use XpsTimerState instead of 'struct timerblock'
Date: Tue, 10 Jan 2023 13:00:00 +0100 [thread overview]
Message-ID: <Y71TQPIv21qOe1ZT@toto> (raw)
In-Reply-To: <20230109140306.23161-15-philmd@linaro.org>
On Mon, Jan 09, 2023 at 03:03:06PM +0100, Philippe Mathieu-Daudé wrote:
> This remove a use of 'struct' in the DECLARE_INSTANCE_CHECKER()
> macro call, to avoid after a QOM refactor:
>
> hw/timer/xilinx_timer.c:65:1: error: declaration of anonymous struct must be a definition
> DECLARE_INSTANCE_CHECKER(struct timerblock, XILINX_TIMER,
> ^
Reviewed-by: Edgar E. Iglesias <edgar@zeroasic.com>
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/timer/xilinx_timer.c | 27 +++++++++++++--------------
> 1 file changed, 13 insertions(+), 14 deletions(-)
>
> diff --git a/hw/timer/xilinx_timer.c b/hw/timer/xilinx_timer.c
> index c7f17cd646..32a9df69e0 100644
> --- a/hw/timer/xilinx_timer.c
> +++ b/hw/timer/xilinx_timer.c
> @@ -62,10 +62,10 @@ struct xlx_timer
> };
>
> #define TYPE_XILINX_TIMER "xlnx.xps-timer"
> -DECLARE_INSTANCE_CHECKER(struct timerblock, XILINX_TIMER,
> - TYPE_XILINX_TIMER)
> +typedef struct XpsTimerState XpsTimerState;
> +DECLARE_INSTANCE_CHECKER(XpsTimerState, XILINX_TIMER, TYPE_XILINX_TIMER)
>
> -struct timerblock
> +struct XpsTimerState
> {
> SysBusDevice parent_obj;
>
> @@ -76,7 +76,7 @@ struct timerblock
> struct xlx_timer *timers;
> };
>
> -static inline unsigned int num_timers(struct timerblock *t)
> +static inline unsigned int num_timers(XpsTimerState *t)
> {
> return 2 - t->one_timer_only;
> }
> @@ -87,7 +87,7 @@ static inline unsigned int timer_from_addr(hwaddr addr)
> return addr >> 2;
> }
>
> -static void timer_update_irq(struct timerblock *t)
> +static void timer_update_irq(XpsTimerState *t)
> {
> unsigned int i, irq = 0;
> uint32_t csr;
> @@ -104,7 +104,7 @@ static void timer_update_irq(struct timerblock *t)
> static uint64_t
> timer_read(void *opaque, hwaddr addr, unsigned int size)
> {
> - struct timerblock *t = opaque;
> + XpsTimerState *t = opaque;
> struct xlx_timer *xt;
> uint32_t r = 0;
> unsigned int timer;
> @@ -155,7 +155,7 @@ static void
> timer_write(void *opaque, hwaddr addr,
> uint64_t val64, unsigned int size)
> {
> - struct timerblock *t = opaque;
> + XpsTimerState *t = opaque;
> struct xlx_timer *xt;
> unsigned int timer;
> uint32_t value = val64;
> @@ -202,7 +202,7 @@ static const MemoryRegionOps timer_ops = {
> static void timer_hit(void *opaque)
> {
> struct xlx_timer *xt = opaque;
> - struct timerblock *t = xt->parent;
> + XpsTimerState *t = xt->parent;
> D(fprintf(stderr, "%s %d\n", __func__, xt->nr));
> xt->regs[R_TCSR] |= TCSR_TINT;
>
> @@ -213,7 +213,7 @@ static void timer_hit(void *opaque)
>
> static void xilinx_timer_realize(DeviceState *dev, Error **errp)
> {
> - struct timerblock *t = XILINX_TIMER(dev);
> + XpsTimerState *t = XILINX_TIMER(dev);
> unsigned int i;
>
> /* Init all the ptimers. */
> @@ -236,16 +236,15 @@ static void xilinx_timer_realize(DeviceState *dev, Error **errp)
>
> static void xilinx_timer_init(Object *obj)
> {
> - struct timerblock *t = XILINX_TIMER(obj);
> + XpsTimerState *t = XILINX_TIMER(obj);
>
> /* All timers share a single irq line. */
> sysbus_init_irq(SYS_BUS_DEVICE(obj), &t->irq);
> }
>
> static Property xilinx_timer_properties[] = {
> - DEFINE_PROP_UINT32("clock-frequency", struct timerblock, freq_hz,
> - 62 * 1000000),
> - DEFINE_PROP_UINT8("one-timer-only", struct timerblock, one_timer_only, 0),
> + DEFINE_PROP_UINT32("clock-frequency", XpsTimerState, freq_hz, 62 * 1000000),
> + DEFINE_PROP_UINT8("one-timer-only", XpsTimerState, one_timer_only, 0),
> DEFINE_PROP_END_OF_LIST(),
> };
>
> @@ -260,7 +259,7 @@ static void xilinx_timer_class_init(ObjectClass *klass, void *data)
> static const TypeInfo xilinx_timer_info = {
> .name = TYPE_XILINX_TIMER,
> .parent = TYPE_SYS_BUS_DEVICE,
> - .instance_size = sizeof(struct timerblock),
> + .instance_size = sizeof(XpsTimerState),
> .instance_init = xilinx_timer_init,
> .class_init = xilinx_timer_class_init,
> };
> --
> 2.38.1
>
next prev parent reply other threads:[~2023-01-10 12:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 14:02 [PATCH 00/14] hw/arm: QOM OBJECT_DECLARE_SIMPLE_TYPE cleanups Philippe Mathieu-Daudé
2023-01-09 14:02 ` [PATCH 01/14] hw/arm/pxa: Avoid forward-declaring PXA2xxI2CState Philippe Mathieu-Daudé
2023-01-09 14:02 ` [PATCH 02/14] hw/gpio/omap_gpio: Add local variable to avoid embedded cast Philippe Mathieu-Daudé
2023-01-09 14:02 ` [PATCH 03/14] hw/arm/omap: Drop useless casts from void * to pointer Philippe Mathieu-Daudé
2023-01-09 14:02 ` [PATCH 04/14] hw/gpio/omap_gpio: Use CamelCase for TYPE_OMAP1_GPIO type name Philippe Mathieu-Daudé
2023-01-09 14:02 ` [PATCH 05/14] hw/gpio/omap_gpio: Use CamelCase for TYPE_OMAP2_GPIO " Philippe Mathieu-Daudé
2023-01-09 14:02 ` [PATCH 06/14] hw/intc/omap_intc: Use CamelCase for TYPE_OMAP_INTC " Philippe Mathieu-Daudé
2023-01-09 14:02 ` [PATCH 07/14] hw/arm/stellaris: Drop useless casts from void * to pointer Philippe Mathieu-Daudé
2023-01-09 14:03 ` [PATCH 08/14] hw/arm/stellaris: Use CamelCase for STELLARIS_ADC type name Philippe Mathieu-Daudé
2023-01-09 14:03 ` [PATCH 09/14] hw/arm/bcm2836: Remove definitions generated by OBJECT_DECLARE_TYPE() Philippe Mathieu-Daudé
2023-01-09 14:03 ` [PATCH 10/14] hw/arm/npcm7xx: Declare QOM macros using OBJECT_DECLARE_SIMPLE_TYPE() Philippe Mathieu-Daudé
2023-01-09 14:03 ` [PATCH 11/14] hw/misc/sbsa_ec: Rename TYPE_SBSA_EC -> TYPE_SBSA_SECURE_EC Philippe Mathieu-Daudé
2023-01-09 14:03 ` [PATCH 12/14] hw/misc/sbsa_ec: Declare QOM macros using OBJECT_DECLARE_SIMPLE_TYPE() Philippe Mathieu-Daudé
2023-01-09 14:03 ` [PATCH 13/14] hw/intc/xilinx_intc: Use 'XpsIntc' typedef instead of 'struct xlx_pic' Philippe Mathieu-Daudé
2023-01-10 11:59 ` Edgar E. Iglesias
2023-01-09 14:03 ` [PATCH 14/14] hw/timer/xilinx_timer: Use XpsTimerState instead of 'struct timerblock' Philippe Mathieu-Daudé
2023-01-10 12:00 ` Edgar E. Iglesias [this message]
2023-01-09 17:59 ` [PATCH 00/14] hw/arm: QOM OBJECT_DECLARE_SIMPLE_TYPE cleanups Richard Henderson
2023-01-12 17:16 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y71TQPIv21qOe1ZT@toto \
--to=edgar.iglesias@gmail.com \
--cc=alistair@alistair23.me \
--cc=eduardo@habkost.net \
--cc=hskinnemoen@google.com \
--cc=kfting@nuvoton.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).