qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] tests/qemu-iotests/312: Mark "quorum" as required driver
@ 2023-01-04 11:46 Thomas Huth
  2023-01-04 12:24 ` Philippe Mathieu-Daudé
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Thomas Huth @ 2023-01-04 11:46 UTC (permalink / raw)
  To: qemu-block, Kevin Wolf, Hanna Reitz; +Cc: qemu-devel, Alberto Garcia

"quorum" is required by iotest 312 - if it is not compiled into the
QEMU binary, the test fails. Thus list "quorum" as required driver
so that the test gets skipped in case it is not available.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/qemu-iotests/312 | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/qemu-iotests/312 b/tests/qemu-iotests/312
index 4139745f0e..0d9ea09a31 100755
--- a/tests/qemu-iotests/312
+++ b/tests/qemu-iotests/312
@@ -52,6 +52,7 @@ _supported_fmt qcow2
 _supported_proto file
 _supported_os Linux
 _unsupported_imgopts cluster_size data_file
+_require_drivers quorum
 
 echo
 echo '### Create all images' # three source (quorum), one destination
-- 
2.31.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] tests/qemu-iotests/312: Mark "quorum" as required driver
  2023-01-04 11:46 [PATCH] tests/qemu-iotests/312: Mark "quorum" as required driver Thomas Huth
@ 2023-01-04 12:24 ` Philippe Mathieu-Daudé
  2023-01-05 17:19 ` Alberto Garcia
  2023-01-10 13:04 ` Kevin Wolf
  2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-01-04 12:24 UTC (permalink / raw)
  To: Thomas Huth, qemu-block, Kevin Wolf, Hanna Reitz
  Cc: qemu-devel, Alberto Garcia

On 4/1/23 12:46, Thomas Huth wrote:
> "quorum" is required by iotest 312 - if it is not compiled into the
> QEMU binary, the test fails. Thus list "quorum" as required driver
> so that the test gets skipped in case it is not available.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   tests/qemu-iotests/312 | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] tests/qemu-iotests/312: Mark "quorum" as required driver
  2023-01-04 11:46 [PATCH] tests/qemu-iotests/312: Mark "quorum" as required driver Thomas Huth
  2023-01-04 12:24 ` Philippe Mathieu-Daudé
@ 2023-01-05 17:19 ` Alberto Garcia
  2023-01-10 13:04 ` Kevin Wolf
  2 siblings, 0 replies; 4+ messages in thread
From: Alberto Garcia @ 2023-01-05 17:19 UTC (permalink / raw)
  To: Thomas Huth, qemu-block, Kevin Wolf, Hanna Reitz; +Cc: qemu-devel

On Wed 04 Jan 2023 12:46:01 PM +01, Thomas Huth wrote:
> "quorum" is required by iotest 312 - if it is not compiled into the
> QEMU binary, the test fails. Thus list "quorum" as required driver
> so that the test gets skipped in case it is not available.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Alberto Garcia <berto@igalia.com>

Berto


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] tests/qemu-iotests/312: Mark "quorum" as required driver
  2023-01-04 11:46 [PATCH] tests/qemu-iotests/312: Mark "quorum" as required driver Thomas Huth
  2023-01-04 12:24 ` Philippe Mathieu-Daudé
  2023-01-05 17:19 ` Alberto Garcia
@ 2023-01-10 13:04 ` Kevin Wolf
  2 siblings, 0 replies; 4+ messages in thread
From: Kevin Wolf @ 2023-01-10 13:04 UTC (permalink / raw)
  To: Thomas Huth; +Cc: qemu-block, Hanna Reitz, qemu-devel, Alberto Garcia

Am 04.01.2023 um 12:46 hat Thomas Huth geschrieben:
> "quorum" is required by iotest 312 - if it is not compiled into the
> QEMU binary, the test fails. Thus list "quorum" as required driver
> so that the test gets skipped in case it is not available.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Thanks, applied to the block branch.

Kevin



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-01-10 15:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-04 11:46 [PATCH] tests/qemu-iotests/312: Mark "quorum" as required driver Thomas Huth
2023-01-04 12:24 ` Philippe Mathieu-Daudé
2023-01-05 17:19 ` Alberto Garcia
2023-01-10 13:04 ` Kevin Wolf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).