* [PATCH] tests/qemu-iotests/262: Check for availability of "blkverify" first
@ 2023-01-04 11:28 Thomas Huth
2023-01-04 12:25 ` Philippe Mathieu-Daudé
2023-01-10 13:18 ` Kevin Wolf
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Huth @ 2023-01-04 11:28 UTC (permalink / raw)
To: qemu-block, Kevin Wolf; +Cc: qemu-devel, Hanna Reitz
In downstream RHEL builds, we do not have "blkverify" enabled, so
iotest 262 is currently failing there. Thus let's list "blkverify"
as required item so that the test properly gets skipped instead if
"blkverify" is missing.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qemu-iotests/262 | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/262 b/tests/qemu-iotests/262
index 2294fd5ecb..a4a92de45a 100755
--- a/tests/qemu-iotests/262
+++ b/tests/qemu-iotests/262
@@ -25,7 +25,8 @@ import iotests
import os
iotests.script_initialize(supported_fmts=['qcow2'],
- supported_platforms=['linux'])
+ supported_platforms=['linux'],
+ required_fmts=['blkverify'])
with iotests.FilePath('img') as img_path, \
iotests.FilePath('mig_fifo') as fifo, \
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] tests/qemu-iotests/262: Check for availability of "blkverify" first
2023-01-04 11:28 [PATCH] tests/qemu-iotests/262: Check for availability of "blkverify" first Thomas Huth
@ 2023-01-04 12:25 ` Philippe Mathieu-Daudé
2023-01-10 13:18 ` Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-01-04 12:25 UTC (permalink / raw)
To: Thomas Huth, qemu-block, Kevin Wolf; +Cc: qemu-devel, Hanna Reitz
On 4/1/23 12:28, Thomas Huth wrote:
> In downstream RHEL builds, we do not have "blkverify" enabled, so
> iotest 262 is currently failing there. Thus let's list "blkverify"
> as required item so that the test properly gets skipped instead if
> "blkverify" is missing.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/qemu-iotests/262 | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tests/qemu-iotests/262: Check for availability of "blkverify" first
2023-01-04 11:28 [PATCH] tests/qemu-iotests/262: Check for availability of "blkverify" first Thomas Huth
2023-01-04 12:25 ` Philippe Mathieu-Daudé
@ 2023-01-10 13:18 ` Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2023-01-10 13:18 UTC (permalink / raw)
To: Thomas Huth; +Cc: qemu-block, qemu-devel, Hanna Reitz
Am 04.01.2023 um 12:28 hat Thomas Huth geschrieben:
> In downstream RHEL builds, we do not have "blkverify" enabled, so
> iotest 262 is currently failing there. Thus let's list "blkverify"
> as required item so that the test properly gets skipped instead if
> "blkverify" is missing.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-10 14:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-04 11:28 [PATCH] tests/qemu-iotests/262: Check for availability of "blkverify" first Thomas Huth
2023-01-04 12:25 ` Philippe Mathieu-Daudé
2023-01-10 13:18 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).