From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2AD9AC54EBE for ; Tue, 10 Jan 2023 19:29:51 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pFKHj-0000dQ-6k; Tue, 10 Jan 2023 14:27:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFKHh-0000cR-0D for qemu-devel@nongnu.org; Tue, 10 Jan 2023 14:27:45 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFKHe-0000bq-Ne for qemu-devel@nongnu.org; Tue, 10 Jan 2023 14:27:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673378861; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fNNPggZOIwpsQZhHOFl126vE235Q5/C4TxrJWTgFblg=; b=BJdoQSvKt0KHP/CgmX964xkW8hVn6clq8Rh4ImS/nqlvCK5o/7sD25aeyYt+zXTq1X+CpG fKm0WAtAVRPF+Hvfpp2A7NI2rdTRfiiignXKTCqqaYiltRktvcDTqmhKkfPGTX/96N/jXk 6mUmSTD39QjYkLUynWYyLzXULHzFycg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-37-mB_OqraMPKag2wObuw2CRw-1; Tue, 10 Jan 2023 14:27:38 -0500 X-MC-Unique: mB_OqraMPKag2wObuw2CRw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AF9BB101A52E; Tue, 10 Jan 2023 19:27:37 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.56]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 38685140EBF4; Tue, 10 Jan 2023 19:27:36 +0000 (UTC) Date: Tue, 10 Jan 2023 19:27:33 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Stefan Berger Cc: Peter Maydell , QEMU Developers , Eric Auger , Alex =?utf-8?Q?Benn=C3=A9e?= , Thomas Huth , Laurent Vivier , Paolo Bonzini Subject: Re: intermittent hang, s390x host, bios-tables-test test, TPM Message-ID: References: <32c53c77-5827-7839-94a1-73003bc3f8af@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Jan 10, 2023 at 01:50:26PM -0500, Stefan Berger wrote: > > > On 1/6/23 10:16, Stefan Berger wrote: >> This here seems to be the root cause. An unknown control channel >> command was received from the TPM emulator backend by the control channel thread and we end up in g_assert_not_reached(). > > > > https://github.com/qemu/qemu/blob/master/tests/qtest/tpm-emu.c#L189 > > > > > > > >         ret = qio_channel_read(ioc, (char *)&cmd, sizeof(cmd), NULL); > >         if (ret <= 0) { > >             break; > >         } > > > >         cmd = be32_to_cpu(cmd); > >         switch (cmd) { > >  [...] > >         default: > >             g_debug("unimplemented %u", cmd); > >             g_assert_not_reached();                <------------------ > >         } > > > > I will run this test case in an endless loop on an x86_64 host and see what we get there ... > > I could not recreate the issue running the test on a ppc64 and x86_64 > host. There we like >100k test runs on ppc64 and >40k on x86_64. Also > simulating the reception of an unsupported command did not lead to a > hang like shown here. Assuming your ppc64 host is running an little endian OS, and we're only seeing the test failure on s390x, then it points towards the problem being an endianness issue in the TPM code. Something missing a byteswap somewhere along the way ? With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|