From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78FAFC54EBC for ; Tue, 10 Jan 2023 17:42:42 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pFIKq-00051t-U4; Tue, 10 Jan 2023 12:22:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFIKj-0004yL-L6 for qemu-devel@nongnu.org; Tue, 10 Jan 2023 12:22:47 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFIKi-0006PO-4O for qemu-devel@nongnu.org; Tue, 10 Jan 2023 12:22:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673371362; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m3wt/tgxHIMBi+RqkmcZBdzr5E0C09GLNpHch/hhFn4=; b=T8pFBjmEgxKvabtm8BllHj3rKLhUDKlicLrXFP3uqXM9Llo9Hkkn6160OwQeKgVB1N5Gpn wSNJOfNe98CDmMvdHz2rGk7JU8Wl5D7smb1Uz31QonD4++J00fygA6Mhdf6eWOq2+I8/H4 q3+H9RzUpODVzYIMhY+FTBE5jTEUUPE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-658-kVbgJrU7NFaWxbDCTDf9pg-1; Tue, 10 Jan 2023 12:22:38 -0500 X-MC-Unique: kVbgJrU7NFaWxbDCTDf9pg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2F55E8828C2; Tue, 10 Jan 2023 17:22:38 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.56]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1A1A7C16031; Tue, 10 Jan 2023 17:22:36 +0000 (UTC) Date: Tue, 10 Jan 2023 17:22:34 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Peter Maydell Cc: qemu-devel@nongnu.org, Paolo Bonzini , Thomas Huth , Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH] Makefile: allow 'make uninstall' Message-ID: References: <20230110151318.24462-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230110151318.24462-1-peter.maydell@linaro.org> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Jan 10, 2023 at 03:13:18PM +0000, Peter Maydell wrote: > Meson supports an "uninstall", so we can easily allow it to work by > not suppressing the forwarding of it from Make to meson. > > We originally suppressed this because Meson's 'uninstall' has a hole > in it: it will remove everything that is installed by a mechanism > meson knows about, but not things installed by "custom install > scripts", and there is no "custom uninstall script" mechanism. > > For QEMU, though, the only thing that was being installed by a custom > install script was the LC_MESSAGES files handled by Meson's i18n > module, and that code was fixed in Meson commit 487d45c1e5bfff0fbdb4, > which is present in Meson 0.60.0 and later. Since we already require > a Meson version newer than that, we're now safe to enable > 'uninstall', as it will now correctly uninstall everything that was > installed. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/109 > Signed-off-by: Peter Maydell > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|