qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, David Hildenbrand <david@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	qemu-trivial@nongnu.org, Mark Burton <mburton@qti.qualcomm.com>
Subject: Re: [PATCH] memory: Do not print MR priority in flatview HMP output
Date: Tue, 3 Jan 2023 16:48:56 -0500	[thread overview]
Message-ID: <Y7SiyMhw9yLX/eG9@x1n> (raw)
In-Reply-To: <20221228130439.80341-1-philmd@linaro.org>

On Wed, Dec 28, 2022 at 02:04:39PM +0100, Philippe Mathieu-Daudé wrote:
> When requesting the flatview output with 'info mtree -f',
> the MemoryRegion priority is irrelevant and noise. Remove it.

It is in many cases still helpful debugging information to me.

Maybe it's because it can cause mis-alignment when the priority >= 10?  If
that's the case, how about tabbing it properly instead of removing?

Thanks,

-- 
Peter Xu



      parent reply	other threads:[~2023-01-03 21:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-28 13:04 [PATCH] memory: Do not print MR priority in flatview HMP output Philippe Mathieu-Daudé
2022-12-28 16:26 ` Mark Burton
2022-12-28 18:51   ` Philippe Mathieu-Daudé
2023-01-03 21:48 ` Peter Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y7SiyMhw9yLX/eG9@x1n \
    --to=peterx@redhat.com \
    --cc=david@redhat.com \
    --cc=mburton@qti.qualcomm.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).