From: Stefan Hajnoczi <stefanha@redhat.com>
To: Alessandro Di Federico <ale@rev.ng>
Cc: qemu-devel@nongnu.org, Thomas Huth <thuth@redhat.com>,
Taylor Simpson <tsimpson@quicinc.com>,
Anton Johansson <anjo@rev.ng>,
philmd@linaro.org, peter.maydell@linaro.org, bcain@quicinc.com,
quic_mathbern@quicinc.com
Subject: Re: [PATCH] Update scripts/meson-buildoptions.sh
Date: Wed, 4 Jan 2023 09:39:30 -0500 [thread overview]
Message-ID: <Y7WPoq2d/J0ZUpXG@fedora> (raw)
In-Reply-To: <20230102104113.3438895-1-ale@rev.ng>
[-- Attachment #1: Type: text/plain, Size: 686 bytes --]
On Mon, Jan 02, 2023 at 11:41:13AM +0100, Alessandro Di Federico wrote:
> Note: `Makefile` relies on modification dates in the source tree to
> detect changes to `meson_options.txt`. However, git does not track
> those. Therefore, the following was necessary to regenerate
> `meson-buildoptions.sh`:
>
> touch meson_options.txt
> cd "$BUILD_DIR"
> make update-buildoptions
>
> Signed-off-by: Alessandro Di Federico <ale@rev.ng>
> ---
> scripts/meson-buildoptions.sh | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)
The discussion we're having is independent of this patch:
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2023-01-04 14:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-02 10:41 [PATCH] Update scripts/meson-buildoptions.sh Alessandro Di Federico via
2023-01-03 14:14 ` Thomas Huth
2023-01-03 14:37 ` Stefan Hajnoczi
2023-01-03 15:26 ` Alessandro Di Federico via
2023-01-03 15:51 ` Stefan Hajnoczi
2023-01-03 16:11 ` Alessandro Di Federico via
2023-01-03 17:30 ` Peter Maydell
2023-01-03 19:31 ` Stefan Hajnoczi
2023-01-07 18:02 ` Paolo Bonzini
2023-01-09 1:59 ` Richard Henderson
2023-01-04 14:39 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7WPoq2d/J0ZUpXG@fedora \
--to=stefanha@redhat.com \
--cc=ale@rev.ng \
--cc=anjo@rev.ng \
--cc=bcain@quicinc.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_mathbern@quicinc.com \
--cc=thuth@redhat.com \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).