Re: [PATCH] po/meson: make i18n module optional

["Daniel P. Berrangé" <berrange@redhat.com>]

On Tue, Jan 24, 2023 at 03:47:24AM +0000, Anton Kochkov wrote:
> This is necessary for Muon build system compatibility and
> prevents the following error:

This raises the question of whether we actually want Muon compatibility
in the first place though. IMHO one of the good benefits of Meson (and
all other modern build systems), is that application maintainers no
longer need to worry about portability between the many OS specific
re-implementations of 'make'. Personally I feel pretty unethusiastic
at the prospect of going back to that world by adding workarounds for
incomplete re-implementations of meson.

What is the compelling reason that users of QEMU need to use the
imcomplete Muon re-implementation, instead of sticking with official
Meson releases that QEMU maintainers actually test against on all
our targetted OS platforms ?

> meson.build:4:8: error module 'i18n' is unimplemented,
>   If you would like to make your build files portable to muon,
>   use `import('i18n', required: false)`,
>   and then check the .found() method before use.
>   4 |   i18n.gettext(meson.project_name(),
>              ^
> qemu/meson.build:3640:3: error in function subdir()
> 3640 |   subdir('po')
>          ^
> 
> Signed-off-by: Anton Kochkov <anton.kochkov@proton.me>
> ---
>  po/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/po/meson.build b/po/meson.build
> index a863f0575f..f7be95cf5f 100644
> --- a/po/meson.build
> +++ b/po/meson.build
> @@ -1,4 +1,4 @@
> -i18n = import('i18n')
> +i18n = import('i18n', required: false)
> 
>  if find_program('xgettext', required: get_option('gettext')).found()
>    i18n.gettext(meson.project_name(),
> --
> 2.39.1
> 
> 
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|