From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6424C05027 for ; Mon, 23 Jan 2023 16:24:04 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJzbm-0007mi-Ak; Mon, 23 Jan 2023 11:23:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJzbj-0007mJ-Na for qemu-devel@nongnu.org; Mon, 23 Jan 2023 11:23:43 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJzbh-0003cw-HW for qemu-devel@nongnu.org; Mon, 23 Jan 2023 11:23:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674491020; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zizKysvyVtiKNbeU+UAe1Y/sVDNRg53UqbVnWeRahsM=; b=B32hv746sO53SmpiIGjCPfTuEzaIdxgCT68gDPkExdelQKJkmrHZ7lvBsy9tuFvigCD3or LcReogWYdU4n3vgBK2zk5657qra/zktjJw4caMP+lRHhwmHrGMaX2vRu/HO8gDQw22Qxmv XMYPb5oR54o+YWgy9zR5xVIqLnZVrl0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-110-4Zu1mJ-4PfyNJ3qUakhxXw-1; Mon, 23 Jan 2023 11:23:36 -0500 X-MC-Unique: 4Zu1mJ-4PfyNJ3qUakhxXw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 47BB3811E6E; Mon, 23 Jan 2023 16:23:36 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.197]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D1184492C3E; Mon, 23 Jan 2023 16:23:34 +0000 (UTC) Date: Mon, 23 Jan 2023 16:23:32 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: Thomas Huth , Bin Meng , Stefan Weil , QEMU Developers Subject: Re: MSYS2 and libfdt Message-ID: References: <839268cb-b65c-68d6-1294-47548ed383b1@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Jan 20, 2023 at 05:57:29PM +0400, Marc-André Lureau wrote: > Hi Thomas > > On Fri, Jan 20, 2023 at 12:31 PM Thomas Huth wrote: > > > > On 19/01/2023 09.56, Marc-André Lureau wrote: > > > Hi > > > > > > On Thu, Jan 19, 2023 at 12:31 PM Thomas Huth wrote: > > >> > > >> > > >> Hi all, > > >> > > >> in some spare minutes, I started playing with a patch to try to remove the > > >> dtc submodule from the QEMU git repository - according to > > >> https://repology.org/project/dtc/versions our supported build platforms > > >> should now all provide the minimum required version. > > >> > > >> However, I'm hitting a problem with Windows / MSYS2 in the CI jobs: The > > >> libfdt is packaged as part of the dtc package there: > > >> > > >> https://packages.msys2.org/package/dtc > > >> > > >> ... meaning that it is added with a usr/include and usr/lib path prefix > > >> instead of mingw64/include and mingw64/lib like other packages are using > > >> (see e.g. > > >> https://packages.msys2.org/package/mingw-w64-x86_64-zlib?repo=mingw64). Thus > > >> the compiler does not find the library there. Also there does not seem to be > > >> a difference between a i686 (32-bit) and x86_64 (64-bit) variant available > > >> here? Does anybody know how libfdt is supposed to be used with MSYS2 ? > > > > > > The msys environment is a bit special, it's not an environment for a > > > particular build target, my understanding is that it holds common > > > files/tools. > > > > > > dtc should be added to https://github.com/msys2/MINGW-packages for it > > > to be available as a target dependency. > > > > Do you have already any experience in requesting a new package there? Could > > you maybe do it? ... since I don't have a proper MinGW installation here, it > > would be very cumbersome for me right now. > > > > Here you go (although let see what CI has to say): > https://github.com/msys2/MINGW-packages/pull/15168 > > The msys2 maintainers are usually very quick and helpful, in my experience. And it merged 1 day after you posted it. So yes, the msys2 maintainers are indeed very quick & helpful :-) So in theory we can try to drop the submodule for dtc now With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|