From: "Daniel P. Berrangé" <berrange@redhat.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, paul <paul@xen.org>
Subject: Re: [PATCH] remove unnecessary extern "C" blocks
Date: Thu, 12 Jan 2023 13:17:40 +0000 [thread overview]
Message-ID: <Y8AIdFk8NL8eKQdL@redhat.com> (raw)
In-Reply-To: <afc99f0cdfd9686e99a6e1b94e609dc0e73cff43.camel@infradead.org>
On Thu, Jan 12, 2023 at 01:10:13PM +0000, David Woodhouse wrote:
> On Tue, 2023-01-10 at 09:49 +0100, Paolo Bonzini wrote:
> > A handful of header files in QEMU are wrapped with extern "C" blocks.
> > These are not necessary: there are C++ source files anymore in QEMU,
> > and even where there were some, they did not include most of these
> > files anyway.
> >
> > Remove them for consistency.
>
>
> Are we allowed C++ in qemu?
Not any more, we've just made an effort to eliminate the last part
of QEMU emulator related code that was C++. All that's left is
one part of the Windows installer for the guest agent.
> I ask because we have a full single-tenant implementation of XenStore
> lying around, designed to be VMM-internal... that just happens to be
> written in C++.
That's unfortunate :-(
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2023-01-12 13:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 8:49 [PATCH] remove unnecessary extern "C" blocks Paolo Bonzini
2023-01-10 9:38 ` Daniel P. Berrangé
2023-01-10 10:53 ` Peter Maydell
2023-01-11 9:14 ` Paolo Bonzini
2023-01-12 11:05 ` Peter Maydell
2023-01-13 8:27 ` Paolo Bonzini
2023-01-12 13:10 ` David Woodhouse
2023-01-12 13:14 ` Peter Maydell
2023-01-12 13:17 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8AIdFk8NL8eKQdL@redhat.com \
--to=berrange@redhat.com \
--cc=dwmw2@infradead.org \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).