From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC19EC54EBD for ; Fri, 13 Jan 2023 12:39:51 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pGJJq-0000Tm-6T; Fri, 13 Jan 2023 07:38:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGJJo-0000T6-LO; Fri, 13 Jan 2023 07:38:00 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGJJm-000636-8g; Fri, 13 Jan 2023 07:38:00 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id CA0905C0051; Fri, 13 Jan 2023 07:37:56 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 13 Jan 2023 07:37:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1673613476; x=1673699876; bh=Aw x3Ut4SGrw2bnO5rBD9JVRTiduH9lOsI4n2DNZJjiY=; b=pzf6qZ5WJy6E/jZdLV hW89Etprgi/KATrVuP9CX9/0v1eAqhh6sjxH7EYrLv22gqWrff0aU3XhyA128FD+ yH5DKjMTaoCZq0icpfLrdnYZ2SfU38X3KOSeUdpHROPaARt+R+FZIz19tk+kHdgb sEV0qTcNlHOH7Z1xWbz42xGZ/QVMkDVRqmOGHSFgTXdQkdyzxCJmXslSkfdl0950 Hy9fEYfzo8nxABEG2zdWx41FKXLasMU2wr6soGt/2q4+f1v1dS82mfeBsgFm1r4s LrglR6N8iKz8KSn22tadES7jVVaLKtXpE8vd9YJUr6cXzw28GP+G8cEeCI6/BrNU E3/Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1673613476; x=1673699876; bh=Awx3Ut4SGrw2bnO5rBD9JVRTiduH 9lOsI4n2DNZJjiY=; b=SqyNWkn9Hz2NFKfM4TOi9SHK7qlvTVQePBqztIvYJrQP 9lr+VcXBkbI1VQcHkViRCOkbOpzRd9sC0XM7k9FqLMf42Dl89+yijg2goDDCsTnx Cpy+NX0iXIsRVAcncrw9qi6PxXpJKgbQPq28QjtGhQbuX/e/wkMZpYazFEN6Jt22 unuwlWNWq+Uu8JxKZ3tABaM9cBfecn8umIaGXc34pRdGO7kVoFRfjeAOp9wWrO8l JJNnrlMeN4c0ev66/5kXDwngnIBHj/rTMrlT7teFqV+eeexEZo8b23A6avulNYff ZUHSgCQzUmckV6czHZIG2MiP0uCOg0SXx8PCajDQ6w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrleekgdefkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpefmlhgruhhs ucflvghnshgvnhcuoehithhssehirhhrvghlvghvrghnthdrughkqeenucggtffrrghtth gvrhhnpeejgfejfeffvdeuhfeifefhgffgueelhedukeevjeevtdduudegieegteffffej veenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehith hssehirhhrvghlvghvrghnthdrughk X-ME-Proxy: Feedback-ID: idc91472f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 13 Jan 2023 07:37:53 -0500 (EST) Date: Fri, 13 Jan 2023 13:37:50 +0100 From: Klaus Jensen To: Peter Maydell Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org, qemu-block@nongnu.org, qemu-devel@nongnu.org, Guenter Roeck , "Michael S. Tsirkin" , Marcel Apfelbaum Subject: Re: completion timeouts with pin-based interrupts in QEMU hw/nvme Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GDbzrrQ6Xxiht77F" Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=66.111.4.28; envelope-from=its@irrelevant.dk; helo=out4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --GDbzrrQ6Xxiht77F Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Jan 13 12:32, Peter Maydell wrote: > On Fri, 13 Jan 2023 at 08:55, Klaus Jensen wrote: > > > > +CC qemu pci maintainers > > > > Michael, Marcel, > > > > Do you have any comments on this thread? As you can see one solution is > > to simply deassert prior to asserting, the other is to reintroduce a > > pci_irq_pulse(). Both seem to solve the issue. >=20 > Both seem to be missing any analysis of "this is what is > happening, this is where we differ from hardware, this > is why this is the correct fix". We shouldn't put in > random "this seems to happen to cause the guest to boot" > fixes, please. >=20 No, I'd like to get to the bottom of this, which is why I'm reaching out to the pci maintainers to get an idea about if this is a general/known issue with pin based interrupts on pci. There are a fair amount of uses of pci_irq_pulse() still left in the tree. --GDbzrrQ6Xxiht77F Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmPBUJ4ACgkQTeGvMW1P Dek3xwf/arpcGt6Lgj2IiknKb/+M7NYjx9H90bEk28jB0sZ4MCcsOt6Ltl3CxmIf kImorYKhR3/Pr+jjNlMrI7b92uA1UXxSQVIMFuXioj79dS/Vk/NSnytb4Z7rGnOB Kxk/ePDY+bVXxS65wRay05g+f6dbxYkxYies4QZqqvQ6GCKzJAI7NLGgK46koFSz nwj4phUhunGlyTiOEWd4KyJQMtiaMvf8rj01VVQ0/a8o9yxaQN/PUHm/dO/R+Cpy PsFsmnChtMh5UfByRnm4BF0B7dk7Bjmr7mBNP2/3PBFQgPl9hBO09hsw2QFUy+yp vy3YwNuajIPJT8a/qorlYehyJXXV+A== =WpH1 -----END PGP SIGNATURE----- --GDbzrrQ6Xxiht77F--