From: Peter Delevoryas <peter@pjd.dev>
To: patrick@stwcx.xyz, clg@kaod.org, peter.maydell@linaro.org,
andrew@aj.id.au, hskinnemoen@google.com, kfting@nuvoton.com,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 0/6] hw/nvram/eeprom_at24c: Cleanup + FRUID EEPROM init example
Date: Sat, 14 Jan 2023 09:07:27 -0800 [thread overview]
Message-ID: <Y8LhT0sinfZdMmHu@pdel-mbp> (raw)
In-Reply-To: <20230114170151.87833-1-peter@pjd.dev>
On Sat, Jan 14, 2023 at 09:01:45AM -0800, Peter Delevoryas wrote:
> This cleans up some of the code we have creating at24c-eeprom objects in the
> Aspeed and Nuvoton files, and adds an example of how to initialize a FRUID
> EEPROM with static data using I2C transfers.
>
> Initially I was going to propose a patch to update the at24c-eeprom realize
> function to incorporate static data, but then I realized I could just
> accomplish the same thing using i2c_send in board reset. The patch at the end
> demonstrates this.
1. I messed up Joel's email on this thread, sorry about that.
2. I forgot to post the output of the test I used to verify this:
qemu-system-aarch64 -machine fby35-bmc -nographic -mtdblock flash-fby35
...
root@bmc-oob:~# fruid-util bmc
FRU Information : BMC
--------------- : ------------------
Board Mfg Date : Mon Jan 10 21:42:00 2022
Board Mfg : XXXXXX
Board Product : BMC Storage Module
Board Serial : XXXXXXXXXXXXX
Board Part Number : XXXXXXXXXXXXXX
Board FRU ID : 1.0
Board Custom Data 1 : XXXXXXXXX
Board Custom Data 2 : XXXXXXXXXXXXXXXXXX
Product Manufacturer : XXXXXX
Product Name : Yosemite V3.5 EVT2
Product Part Number : XXXXXXXXXXXXXX
Product Version : EVT2
Product Serial : XXXXXXXXXXXXX
Product Asset Tag : XXXXXXX
Product FRU ID : 1.0
Product Custom Data 1 : XXXXXXXXX
Product Custom Data 2 : Config A
A reference flash-fby35 image can be found here:
https://github.com/facebook/openbmc/releases/download/openbmc-e2294ff5d31d/fby35.mtd
>
> Thanks,
> Peter
>
> Peter Delevoryas (6):
> hw/nvram/eeprom_at24c: Add header w/ init helper
> hw/arm/aspeed: Remove local copy of at24c_eeprom_init
> hw/arm/aspeed: Replace aspeed_eeprom_init with at24c_eeprom_init
> hw/arm/npcm7xx: Remove local copy of at24c_eeprom_init
> hw/nvram/eeprom_at24c: Add I2C write helper
> hw/arm/aspeed: Init fby35 BMC FRUID EEPROM
>
> hw/arm/aspeed.c | 154 +++++++++++++++++++-------------
> hw/arm/npcm7xx_boards.c | 20 ++---
> hw/nvram/eeprom_at24c.c | 25 ++++++
> include/hw/nvram/eeprom_at24c.h | 12 +++
> 4 files changed, 135 insertions(+), 76 deletions(-)
> create mode 100644 include/hw/nvram/eeprom_at24c.h
>
> --
> 2.39.0
>
>
prev parent reply other threads:[~2023-01-14 17:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-14 17:01 [PATCH 0/6] hw/nvram/eeprom_at24c: Cleanup + FRUID EEPROM init example Peter Delevoryas
2023-01-14 17:01 ` [PATCH 1/6] hw/nvram/eeprom_at24c: Add header w/ init helper Peter Delevoryas
2023-01-16 11:13 ` Cédric Le Goater
2023-01-16 12:23 ` Philippe Mathieu-Daudé
2023-01-16 17:21 ` Peter Delevoryas
2023-01-14 17:01 ` [PATCH 2/6] hw/arm/aspeed: Remove local copy of at24c_eeprom_init Peter Delevoryas
2023-01-16 11:13 ` Cédric Le Goater
2023-01-16 12:24 ` Philippe Mathieu-Daudé
2023-01-16 17:21 ` Peter Delevoryas
2023-01-14 17:01 ` [PATCH 3/6] hw/arm/aspeed: Replace aspeed_eeprom_init with at24c_eeprom_init Peter Delevoryas
2023-01-16 11:14 ` Cédric Le Goater
2023-01-16 12:25 ` Philippe Mathieu-Daudé
2023-01-14 17:01 ` [PATCH 4/6] hw/arm/npcm7xx: Remove local copy of at24c_eeprom_init Peter Delevoryas
2023-01-16 11:14 ` Cédric Le Goater
2023-01-16 12:26 ` Philippe Mathieu-Daudé
2023-01-14 17:01 ` [PATCH 5/6] hw/nvram/eeprom_at24c: Add I2C write helper Peter Delevoryas
2023-01-14 17:01 ` [PATCH 6/6] hw/arm/aspeed: Init fby35 BMC FRUID EEPROM Peter Delevoryas
2023-01-16 12:30 ` Philippe Mathieu-Daudé
2023-01-16 17:23 ` Peter Delevoryas
2023-01-17 6:47 ` Philippe Mathieu-Daudé
2023-01-17 17:49 ` Peter Delevoryas
2023-01-16 12:42 ` Cédric Le Goater
2023-01-16 17:19 ` Peter Delevoryas
2023-01-14 17:07 ` Peter Delevoryas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8LhT0sinfZdMmHu@pdel-mbp \
--to=peter@pjd.dev \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=hskinnemoen@google.com \
--cc=kfting@nuvoton.com \
--cc=patrick@stwcx.xyz \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).