From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85B9AC54EBE for ; Mon, 16 Jan 2023 11:28:05 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHNeQ-0005ZH-Dn; Mon, 16 Jan 2023 06:27:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHNeG-0005Vj-HW for qemu-devel@nongnu.org; Mon, 16 Jan 2023 06:27:32 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHNeE-0008Hj-9T for qemu-devel@nongnu.org; Mon, 16 Jan 2023 06:27:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673868448; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=u8Qf3xo/g3eYNRkvIojUC+bvtYMZbNXVj18sc6TukiM=; b=igsvq1dpQVvZOrG/ys3mVwYocn1bBSrqIjQF03hUP7Jp5C5MsBUVtZ7QmAudjcFOw37BhY H3OHYDUj97TX3G7CBLA/nQ2N5t8ggCRtsOExUWuhPyMELe1Bh5ch+DMJl5hhgnXnmrGlIi smmffOAjUg0xZZB++/+KfoWC5vb3ECw= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-454-RAV2W3UlNVyz1JKMmfQC5A-1; Mon, 16 Jan 2023 06:27:25 -0500 X-MC-Unique: RAV2W3UlNVyz1JKMmfQC5A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4AF141C06EE0; Mon, 16 Jan 2023 11:27:25 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.143]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 23E9F40C6EC4; Mon, 16 Jan 2023 11:27:24 +0000 (UTC) Date: Mon, 16 Jan 2023 11:27:22 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: zhenwei pi Cc: "Michael S. Tsirkin" , arei.gonglei@huawei.com, dgilbert@redhat.com, eblake@redhat.com, armbru@redhat.com, michael.roth@amd.com, pbonzini@redhat.com, qemu-devel@nongnu.org Subject: Re: Re: [for-8.0 v2 00/11] Refactor cryptodev Message-ID: References: <20221122140756.686982-1-pizhenwei@bytedance.com> <20221220103602-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Jan 16, 2023 at 05:53:07PM +0800, zhenwei pi wrote: > On 12/20/22 23:36, Michael S. Tsirkin wrote: > > On Tue, Nov 22, 2022 at 10:07:45PM +0800, zhenwei pi wrote: > > > v1 -> v2: > > > - fix coding style and use 'g_strjoin()' instead of 'char services[128]' > > > (suggested by Dr. David Alan Gilbert) > > > - wrapper function 'cryptodev_backend_account' to record statistics, and > > > allocate sym_stat/asym_stat in cryptodev base class. see patch: > > > 'cryptodev: Support statistics'. > > > - add more arguments into struct CryptoDevBackendOpInfo, then > > > cryptodev_backend_crypto_operation() uses *op_info only. > > > - support cryptodev QoS settings(BPS&OPS), both QEMU command line and QMP > > > command works fine. > > > - add myself as the maintainer for cryptodev. > > > > > > v1: > > > - introduce cryptodev.json to describe the attributes of crypto device, then > > > drop duplicated type declare, remove some virtio related dependence. > > > - add statistics: OPS and bandwidth. > > > - add QMP command: query-cryptodev > > > - add HMP info command: cryptodev > > > - misc fix: detect akcipher capability instead of exposing akcipher service > > > unconditionally. > > > > > > Can we get ACK on QAPI things please? > > Thanks! > > > > Hi Michael > > I pinged QAPI maintainers, but I got no ACK. > Could you please have a glance at this? I am /not/ a QAPI maintainer, but I've given some review of the patches that touch QAPI. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|