From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B31E1C54EBE for ; Mon, 16 Jan 2023 11:06:01 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHNJ6-00010T-IG; Mon, 16 Jan 2023 06:05:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHNJ0-0000qT-7F for qemu-devel@nongnu.org; Mon, 16 Jan 2023 06:05:36 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHNIw-0004De-TF for qemu-devel@nongnu.org; Mon, 16 Jan 2023 06:05:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673867129; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WktmIpRgSXoBD7HjcYPmcD8TLhUht80Qfh0ZhgdVx/k=; b=fetis+vEFnRyh+teTKyRUoKSByimof6yjtYyRU6U8E9CBZBZUVg4i7iyBYWH24Z8ntLjrW 40dpk5kyLPn71VW/d3DwzY3qSxepS3lbZtAVOdDBf/7yhe0Zgi22EgLln5LAUktxLHWB4w j5fvyTZjhzDjSq/HaKjk6n4A3UXgipg= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-45-peBuON4fPXKM5EPk90yNbA-1; Mon, 16 Jan 2023 06:05:28 -0500 X-MC-Unique: peBuON4fPXKM5EPk90yNbA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2594E29ABA04; Mon, 16 Jan 2023 11:05:28 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.143]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F0D80C15BA0; Mon, 16 Jan 2023 11:05:26 +0000 (UTC) Date: Mon, 16 Jan 2023 11:05:24 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: zhenwei pi Cc: arei.gonglei@huawei.com, mst@redhat.com, dgilbert@redhat.com, eblake@redhat.com, armbru@redhat.com, michael.roth@amd.com, pbonzini@redhat.com, qemu-devel@nongnu.org Subject: Re: [for-8.0 v2 02/11] cryptodev: Remove 'name' & 'model' fields Message-ID: References: <20221122140756.686982-1-pizhenwei@bytedance.com> <20221122140756.686982-3-pizhenwei@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221122140756.686982-3-pizhenwei@bytedance.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Nov 22, 2022 at 10:07:47PM +0800, zhenwei pi wrote: > We have already used qapi to generate crypto device types, this allows > to convert type to a string 'model', so the 'model' field is not > needed. > > And the 'name' field is not used by any backend driver, drop it. > > Signed-off-by: zhenwei pi > --- > backends/cryptodev-builtin.c | 3 +-- > backends/cryptodev-lkcf.c | 2 +- > backends/cryptodev-vhost-user.c | 3 +-- > backends/cryptodev.c | 11 +---------- > include/sysemu/cryptodev.h | 12 +++--------- > 5 files changed, 7 insertions(+), 24 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|