From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7753C63797 for ; Tue, 17 Jan 2023 10:44:05 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHjRI-0002KU-8u; Tue, 17 Jan 2023 05:43:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHjRG-0002KL-O2 for qemu-devel@nongnu.org; Tue, 17 Jan 2023 05:43:34 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHjRE-0006Xj-FP for qemu-devel@nongnu.org; Tue, 17 Jan 2023 05:43:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673952211; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1PgvbalebkdOrCjq8+C5r3zxnhGx1s2Nh9Qsjx2dEFw=; b=RvxakNxfy5xr+uvLyJEmQHML+gpJMakT1/FDNWyptMiOGyhFGw59rKfTqeYetH3Wl64HKG LUYsIAZbFLIKkAy/dni2tTUa8Uqfu3/BydjMvAjXdR6dZgeg7auU0i+8CbYfPYQhrKVACw 7Rr7/6/Ic6hp4dfZRiFVTLhOym5L3ak= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-365-ZUHusLaaMFeTSRdtacXJlw-1; Tue, 17 Jan 2023 05:43:30 -0500 X-MC-Unique: ZUHusLaaMFeTSRdtacXJlw-1 Received: by mail-wm1-f72.google.com with SMTP id o22-20020a05600c511600b003db02b921f1so1647204wms.8 for ; Tue, 17 Jan 2023 02:43:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1PgvbalebkdOrCjq8+C5r3zxnhGx1s2Nh9Qsjx2dEFw=; b=CjyR/MWIdRe9ZpERYc0I2OUeoufdXic+xMiGnBfC1QXO6LfUuXkKdpphLI5kyLBHr1 GjF8+pCHmlRDgn88vc5c6glhGBN8wspT1tR2A7JGmA7rC+9LSWpjNic3oCWtRBh5+DCZ V3yXUDsQ76lCvRW/ixJpYUsFWTYBMsILD9YawxRNWzYJuKy5li6MEvLv9gFwJShBD0f3 081lrAmPfiL33wv6UES3CRU5NuZWd31pyGW3E1Vdpjx6LajGLzO81Qml1sh+hMSc49v7 Jurf7AAw4W+pE7Kc/aBF6Krghqai6tGFSujes81NJf4rWgYH6l5S3BdSH5eKintsYttz e+cA== X-Gm-Message-State: AFqh2krSKyKFuA8zVatiAdwF3FuGqdb1P9U9HVnjdtXT+JTPbwDwUPbC +96Oy4ba3E0M2iwxhJzQ5/LuwSDTIrgArDL9gDRpH1RJe4r3Ncvvu6A3kBlPj6za4q98XRlQQRH bvruQkWVKq2DPXMc= X-Received: by 2002:adf:f64f:0:b0:2be:435:cf7b with SMTP id x15-20020adff64f000000b002be0435cf7bmr2155675wrp.8.1673952208927; Tue, 17 Jan 2023 02:43:28 -0800 (PST) X-Google-Smtp-Source: AMrXdXtE2Y4Exh9Um3GqBuPQGgqncu5FgNsVl6Dr11ffjN2OTdGTjBEnPype6IvF6B8KEgEyNxjp4g== X-Received: by 2002:adf:f64f:0:b0:2be:435:cf7b with SMTP id x15-20020adff64f000000b002be0435cf7bmr2155653wrp.8.1673952208597; Tue, 17 Jan 2023 02:43:28 -0800 (PST) Received: from work-vm (ward-16-b2-v4wan-166627-cust863.vm18.cable.virginm.net. [81.97.203.96]) by smtp.gmail.com with ESMTPSA id b13-20020a05600003cd00b002be07cbefb2sm5373326wrg.18.2023.01.17.02.43.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jan 2023 02:43:28 -0800 (PST) Date: Tue, 17 Jan 2023 10:43:26 +0000 From: "Dr. David Alan Gilbert" To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Cc: Het Gala , qemu-devel@nongnu.org, prerna.saxena@nutanix.com, quintela@redhat.com, pbonzini@redhat.com, armbru@redhat.com, eblake@redhat.com, Manish Mishra , Aravind Retnakaran Subject: Re: [PATCH 1/5] migration: Updated QAPI format for 'migrate' qemu monitor command Message-ID: References: <20221226053329.157905-1-het.gala@nutanix.com> <20221226053329.157905-2-het.gala@nutanix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) Received-SPF: pass client-ip=170.10.129.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org * Daniel P. Berrangé (berrange@redhat.com) wrote: > On Mon, Dec 26, 2022 at 05:33:25AM +0000, Het Gala wrote: > > From: Author Het Gala > > > > Existing 'migrate' QAPI design enforces transport mechanism, ip address > > of destination interface and corresponding port number in the form > > of a unified string 'uri' parameter. This scheme does seem to have an issue > > in it, i.e. double-level encoding of URIs. > > > > The current patch maps existing QAPI design into a well-defined data > > structure - 'MigrateChannel' only from the design perspective. Please note that > > the existing 'uri' parameter is kept untouched for backward compatibility. > > > > Suggested-by: Daniel P. Berrange > > Suggested-by: Manish Mishra > > Suggested-by: Aravind Retnakaran > > Signed-off-by: Het Gala > > --- > > qapi/migration.json | 121 +++++++++++++++++++++++++++++++++++++++++++- > > 1 file changed, 119 insertions(+), 2 deletions(-) > > diff --git a/qapi/migration.json b/qapi/migration.json > > index 88ecf86ac8..753e187ce2 100644 > > --- a/qapi/migration.json > > +++ b/qapi/migration.json > > @@ -1449,12 +1449,108 @@ > > ## > > { 'command': 'migrate-continue', 'data': {'state': 'MigrationStatus'} } > > > > +## > > +# @MigrateTransport: > > +# > > +# The supported communication transport mechanisms for migration > > +# > > +# @socket: Supported communication type between two devices for migration. > > +# Socket is able to cover all of 'tcp', 'unix', 'vsock' and > > +# 'fd' already > > +# > > +# @exec: Supported communication type to redirect migration stream into file. > > +# > > +# @rdma: Supported communication type to redirect rdma type migration stream. > > +# > > +# Since 8.0 > > +## > > +{ 'enum': 'MigrateTransport', > > + 'data': ['socket', 'exec', 'rdma'] } > > + > > +## > > +# @MigrateSocketAddr: > > +# > > +# To support different type of socket. > > +# > > +# @socket-type: Different type of socket connections. > > +# > > +# Since 8.0 > > +## > > +{ 'struct': 'MigrateSocketAddr', > > + 'data': {'socket-type': 'SocketAddress' } } > > + > > +## > > +# @MigrateExecAddr: > > + # > > + # Since 8.0 > > + ## > > +{ 'struct': 'MigrateExecAddr', > > + 'data' : {'exec-str': 'str' } } > > Currently for 'exec:cmdstr' the 'cmdstr' part is a shell command > that is passed > > const char *argv[] = { "/bin/sh", "-c", command, NULL }; > > I have a strong preference for making it possible to avoid use > of shell when spawning commands, since much of thue time it is > not required and has the potential to open up vulnerabilities. > It would be nice to be able to just take the full argv directly > IOW > > { 'struct': 'MigrateExecAddr', > 'data' : {'argv': ['str'] } } > > If the caller wants to keep life safe and simple now they can > use > ["/bin/nc", "-U", "/some/sock"] > > but if they still want to send it via shell, they can also do > so > > ["/bin/sh", "-c", "...arbitrary shell script code...."] > > > + > > +## > > +# @MigrateRdmaAddr: > > +# > > +# Since 8.0 > > +## > > +{ 'struct': 'MigrateRdmaAddr', > > + 'data' : {'rdma-str': 'str' } } > > Loooking at the RDMA code it takes the str, and treats it > as an IPv4 address: > > > addr = g_new(InetSocketAddress, 1); > if (!inet_parse(addr, host_port, NULL)) { > rdma->port = atoi(addr->port); > rdma->host = g_strdup(addr->host); > rdma->host_port = g_strdup(host_port); > } > > so we really ought to accept an InetSocketAddress struct > directly > > { 'struct': 'MigrateRdmaAddr', > 'data' : {'rdma-str': 'InetSocketAddress' } } I think that's probably the right thing to do; there is a native RDMA addressing scheme that people occasionally (once a decade or so) ask about but I don't think we've ever supported it. Dave > > > > + > > +## > > +# @MigrateAddress: > > +# > > +# The options available for communication transport mechanisms for migration > > +# > > +# Since 8.0 > > +## > > +{ 'union' : 'MigrateAddress', > > + 'base' : { 'transport' : 'MigrateTransport'}, > > + 'discriminator' : 'transport', > > + 'data' : { > > + 'socket' : 'MigrateSocketAddr', > > + 'exec' : 'MigrateExecAddr', > > + 'rdma': 'MigrateRdmaAddr' } } > > + > > +## > > +# @MigrateChannelType: > > +# > > +# The supported options for migration channel type requests > > +# > > +# @main: Support request for main outbound migration control channel > > +# > > +# Since 8.0 > > +## > > +{ 'enum': 'MigrateChannelType', > > + 'data': [ 'main'] } > > + > > +## > > +# @MigrateChannel: > > +# > > +# Information regarding migration Channel-type for transferring packets, > > +# source and corresponding destination interface for socket connection > > +# and number of multifd channels over the interface. > > +# > > +# @channeltype: Name of Channel type for transfering packet information > > +# > > +# @addr: SocketAddress of destination interface > > +# > > +# Since 8.0 > > +## > > +{ 'struct': 'MigrateChannel', > > + 'data' : { > > + 'channeltype' : 'MigrateChannelType', > > + 'addr' : 'MigrateAddress' } } > > + > > ## > > # @migrate: > > # > > # Migrates the current running guest to another Virtual Machine. > > # > > # @uri: the Uniform Resource Identifier of the destination VM > > +# for migration thread > > +# > > +# @channel: Struct containing migration channel type, along with all > > +# the details of destination interface required for initiating > > +# a migration stream. > > # > > # @blk: do block migration (full disk copy) > > # > > @@ -1479,15 +1575,36 @@ > > # 3. The user Monitor's "detach" argument is invalid in QMP and should not > > # be used > > # > > +# 4. The uri argument should have the Uniform Resource Identifier of default > > +# destination VM. This connection will be bound to default network > > +# > > +# 5. Both 'uri' and 'channel' arguments, are mututally exclusive but, atleast > > > Minor typos "mutually" "at least" > > > +# one of the two arguments should be present. > > +# > > # Example: > > # > > # -> { "execute": "migrate", "arguments": { "uri": "tcp:0:4446" } } > > # <- { "return": {} } > > # > > +# -> { "execute": "migrate", > > +# "arguments": { > > +# "channel": { "channeltype": "main", > > +# "addr": { "transport": "socket", > > +# "socket-type": { "type': "inet', > > +# "host": "10.12.34.9", > > +# "port": "1050" } } } } } > > +# <- { "return": {} } > > +# > > +# -> { "execute": "migrate", > > +# "arguments": { "channel": { "channeltype": "main", > > +# "addr": { "transport": "exec", > > +# "exec-str": "/tmp/exec" } } } } > > Will need updating given my feedback above > > > +# <- { "return": {} } > > +# > > ## > > { 'command': 'migrate', > > - 'data': {'uri': 'str', '*blk': 'bool', '*inc': 'bool', > > - '*detach': 'bool', '*resume': 'bool' } } > > + 'data': {'*uri': 'str', '*channel': 'MigrateChannel', '*blk': 'bool', > > + '*inc': 'bool', '*detach': 'bool', '*resume': 'bool' } } > > With regards, > Daniel > -- > |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK