From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Cc: qemu-devel@nongnu.org, "Warner Losh" <imp@bsdimp.com>,
"Kyle Evans" <kevans@freebsd.org>,
"Kevin Wolf" <kwolf@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>
Subject: Re: [PATCH 3/3] configure: Enable -Wthread-safety if present
Date: Tue, 17 Jan 2023 14:02:50 +0000 [thread overview]
Message-ID: <Y8aqii6iBsdd5rl6@redhat.com> (raw)
In-Reply-To: <20230117135203.3049709-4-eesposit@redhat.com>
On Tue, Jan 17, 2023 at 08:52:03AM -0500, Emanuele Giuseppe Esposito wrote:
> From: Kevin Wolf <kwolf@redhat.com>
>
> This enables clang's thread safety analysis (TSA), which we'll use to
> statically check the block graph locking.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> Message-Id: <20221207131838.239125-9-kwolf@redhat.com>
> Reviewed-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> configure | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/configure b/configure
> index 2281892657..14668e6269 100755
> --- a/configure
> +++ b/configure
> @@ -1183,6 +1183,7 @@ add_to warn_flags -Wnested-externs
> add_to warn_flags -Wendif-labels
> add_to warn_flags -Wexpansion-to-defined
> add_to warn_flags -Wimplicit-fallthrough=2
> +add_to warn_flags -Wthread-safety
Does this thread safety analysis have any kind of measurable
impact on compilation speed ?
Our CI jobs are quite sensitive to any increase in build
time.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-01-17 14:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 13:52 [PATCH 0/3] TSA: make sure QEMU compiles when using clang TSA Emanuele Giuseppe Esposito
2023-01-17 13:52 ` [PATCH 1/3] util/qemu-thread-posix: use TSA_NO_TSA to suppress clang TSA warnings Emanuele Giuseppe Esposito
2023-01-17 14:33 ` Philippe Mathieu-Daudé
2023-01-17 14:43 ` Emanuele Giuseppe Esposito
2023-01-17 15:49 ` Philippe Mathieu-Daudé
2023-01-17 13:52 ` [PATCH 2/3] bsd-user/mmap: " Emanuele Giuseppe Esposito
2023-01-17 16:16 ` Warner Losh
2023-01-17 16:21 ` Emanuele Giuseppe Esposito
2023-01-17 16:25 ` Kevin Wolf
2023-01-17 16:43 ` Warner Losh
2023-01-17 17:17 ` Kevin Wolf
2023-01-17 20:43 ` Stefan Hajnoczi
2023-01-18 9:14 ` Kevin Wolf
2023-01-18 12:31 ` Stefan Hajnoczi
2023-01-18 15:12 ` Emanuele Giuseppe Esposito
2023-01-18 15:24 ` Stefan Hajnoczi
2023-01-18 17:35 ` Warner Losh
2023-01-17 16:32 ` Stefan Hajnoczi
2023-01-17 13:52 ` [PATCH 3/3] configure: Enable -Wthread-safety if present Emanuele Giuseppe Esposito
2023-01-17 14:02 ` Daniel P. Berrangé [this message]
2023-01-17 14:41 ` Emanuele Giuseppe Esposito
2023-01-17 15:01 ` Daniel P. Berrangé
2023-01-17 15:59 ` Kevin Wolf
2023-01-17 16:22 ` [PATCH 0/3] TSA: make sure QEMU compiles when using clang TSA Stefan Hajnoczi
2023-02-13 10:44 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8aqii6iBsdd5rl6@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=eesposit@redhat.com \
--cc=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).