qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Klaus Jensen <its@irrelevant.dk>
Cc: Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
	Sagi Grimberg <sagi@grimberg.me>,
	linux-nvme@lists.infradead.org, qemu-block@nongnu.org,
	qemu-devel@nongnu.org, Guenter Roeck <linux@roeck-us.net>
Subject: Re: completion timeouts with pin-based interrupts in QEMU hw/nvme
Date: Wed, 18 Jan 2023 15:26:29 -0700	[thread overview]
Message-ID: <Y8hyFcsYbvLOQ+XJ@kbusch-mbp> (raw)
In-Reply-To: <Y8AG21o/9/3eUMIg@cormorant.local>

Klaus,

This isn't going to help your issue, but there are at least two legacy
irq bugs in the nvme qemu implementation.

1. The admin queue breaks if start with legacy and later initialize
msix.

2. The legacy vector is shared among all queues, but it's being
deasserted when the first queue's doorbell makes it empty. It should
remain enabled if any cq is non-empty.

I'll send you some patches for those later. Still working on the real
problem.


  parent reply	other threads:[~2023-01-18 22:27 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-12 13:10 completion timeouts with pin-based interrupts in QEMU hw/nvme Klaus Jensen
2023-01-12 14:26 ` Guenter Roeck
2023-01-12 16:34 ` Keith Busch
2023-01-12 17:45   ` Klaus Jensen
2023-01-12 17:51     ` Keith Busch
2023-01-12 19:14     ` Guenter Roeck
2023-01-12 19:27     ` Keith Busch
2023-01-13  0:27       ` Guenter Roeck
2023-01-12 23:57     ` Guenter Roeck
2023-01-13  8:54 ` Klaus Jensen
2023-01-13 12:32   ` Peter Maydell
2023-01-13 12:37     ` Klaus Jensen
2023-01-13 12:42       ` Peter Maydell
2023-01-13 12:46         ` Klaus Jensen
2023-01-13 16:52     ` Keith Busch
2023-01-16 21:14 ` Klaus Jensen
2023-01-17  4:58   ` Keith Busch
2023-01-17 16:09     ` Guenter Roeck
2023-01-17 16:18       ` Peter Maydell
2023-01-17 19:21         ` Guenter Roeck
2023-01-18 15:04           ` Peter Maydell
2023-01-18 16:33             ` Keith Busch
2023-01-18 23:06               ` Keith Busch
2023-01-19  0:41                 ` Alistair Francis
2023-01-19  2:44                   ` Keith Busch
2023-01-19  3:10                     ` Alistair Francis
2023-01-19  4:03                       ` Keith Busch
2023-01-19  7:28                         ` Klaus Jensen
2023-01-19  8:02                           ` Klaus Jensen
2023-01-19 14:32                             ` Guenter Roeck
2023-01-19 10:35                         ` Peter Maydell
2023-01-17 16:05   ` Guenter Roeck
2023-01-18  4:17 ` Keith Busch
2023-01-18 22:26 ` Keith Busch [this message]
2023-01-19  7:06   ` Klaus Jensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y8hyFcsYbvLOQ+XJ@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=axboe@fb.com \
    --cc=hch@lst.de \
    --cc=its@irrelevant.dk \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux@roeck-us.net \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).