From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE30EC38142 for ; Thu, 19 Jan 2023 07:07:32 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pIP0o-0002Hs-KS; Thu, 19 Jan 2023 02:07:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIP0c-0001x3-QG; Thu, 19 Jan 2023 02:06:50 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIP0a-0000uC-Tq; Thu, 19 Jan 2023 02:06:50 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 941095C00B3; Thu, 19 Jan 2023 02:06:47 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 19 Jan 2023 02:06:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1674112007; x=1674198407; bh=Oc oDLf5RDdyXP/ajFZeKz6pwxOwzzaAjKC8MCDMKbmM=; b=EoKMmNF49pksSpeDZo yC5mLjS3v3F/fSKLYgbsonC428pgp/LZvH/O6FRoe1PnU7lr07aKAECAcqqjdOLN 5V4YR0J2lz55uPZCeu90vFWFkI4egIG4//qnUA5V5kHbkLKPrHbpqahbQc4pdzUj uOe2rl2MkL3sPUbvMANA+DAKXP0ceODWOnqi3rasCFpWBajwWjf5TgAxmah/E5ce PIlI4RCVlWvWeXNfV54bkvPuKYVq66flAudxZwgmriX+DiocFg5H8+mKcAzQZal5 pVmoQDmWhPT8SzOW5/7RB1audfAFXnhPWqnIRYDGc4IxN4+FMFUqj+Z6Ca6Otifd Ta5g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1674112007; x=1674198407; bh=OcoDLf5RDdyXP/ajFZeKz6pwxOwz zaAjKC8MCDMKbmM=; b=A/GiNUgVJ6xVp03h/yfpZV8qXi1Xqbx3oQjldHAvk4Ww KdhlRoGlgoMDqEKLA3QF9yexB7MxLVHRG9paCiHAfN3JlAKHCCnjBoFYBoTKUb/G tQWTERTatDDU4vjDzP2ff1lP5C24kkWUI1odyoQalc1Rc130rJlplAA7rOgasuAS jtXXE6TanaW5OgcHQHJ+7W3MmRbjLHEh045ZBdnGAhctTzh9MCPc7ZuDuDKXHh1l F/Zgmrr1XwGtTtFKVbPjt12132kGABre6lFEehyQHFvwGhfpEx16H0hbuQZXl8yr f+eSjLYLJQr7QvQjlnR3eR72Mn/G9P2H3PvqDf8Rag== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddtledguddtgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpefmlhgr uhhsucflvghnshgvnhcuoehithhssehirhhrvghlvghvrghnthdrughkqeenucggtffrrg htthgvrhhnpeejgfejfeffvdeuhfeifefhgffgueelhedukeevjeevtdduudegieegteff ffejveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hithhssehirhhrvghlvghvrghnthdrughk X-ME-Proxy: Feedback-ID: idc91472f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 19 Jan 2023 02:06:45 -0500 (EST) Date: Thu, 19 Jan 2023 08:06:43 +0100 From: Klaus Jensen To: Keith Busch Cc: Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org, qemu-block@nongnu.org, qemu-devel@nongnu.org, Guenter Roeck Subject: Re: completion timeouts with pin-based interrupts in QEMU hw/nvme Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="DvSWeJSDSDxLn1H0" Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=66.111.4.28; envelope-from=its@irrelevant.dk; helo=out4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --DvSWeJSDSDxLn1H0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Jan 18 15:26, Keith Busch wrote: > Klaus, >=20 > This isn't going to help your issue, but there are at least two legacy > irq bugs in the nvme qemu implementation. >=20 > 1. The admin queue breaks if start with legacy and later initialize > msix. >=20 Hmm. Interesting that we have not encountered this before - is this because the kernel will enable MSI-X early and use it for the admin queue immediately? > 2. The legacy vector is shared among all queues, but it's being > deasserted when the first queue's doorbell makes it empty. It should > remain enabled if any cq is non-empty. I was certain that we fixed this already in commit 83d7ed5c570 ("hw/nvme: fix pin-based interrupt behavior (again)")... --DvSWeJSDSDxLn1H0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmPI7AIACgkQTeGvMW1P Dem3dQgAgtGVD7khXGAEi6BDE6dbp4x8OegdPyeQhaYcIXF0eU52eVH84pLiA90r YgxBGlD8Pyq8/EJz/cCii98sTjr5dQQZaIET2JrkGhAV4zCTe+HGICYiABgK0mxV A3kKZ5ZBzZUHjlB9Lz04ir6AkRrAUZGOBMF0xuc2uBHE40LRfJfUg1Hv4hbWLTRM pELOpavQhgbQr1ToITMJCdWSmIEQSK8hN6hVIlFTe/KCacFOv2tqYYeGg3Viqt4j 1+sFq+DA4UGiI6FjF+r8TIeEozq3+5bYP0KPlLvfA7974sJWQUW6wMF9rXulIIlD EtAYtCkM8yYrRLovwD46LJCYEhAqCQ== =kBIv -----END PGP SIGNATURE----- --DvSWeJSDSDxLn1H0--