From: Kevin Wolf <kwolf@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, Eric Blake <eblake@redhat.com>,
qemu-block@nongnu.org,
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,
qemu-trivial@nongnu.org, Hanna Reitz <hreitz@redhat.com>
Subject: Re: [PATCH-for-8.0] block/nbd: Add missing <qemu/bswap.h> include
Date: Thu, 19 Jan 2023 14:00:09 +0100 [thread overview]
Message-ID: <Y8k+2SXbXab14dFr@redhat.com> (raw)
In-Reply-To: <20221125175328.48539-1-philmd@linaro.org>
Am 25.11.2022 um 18:53 hat Philippe Mathieu-Daudé geschrieben:
> The inlined nbd_readXX() functions call beXX_to_cpu(), themselves
> declared in <qemu/bswap.h>. This fixes when refactoring:
>
> In file included from ../../block/nbd.c:44:
> include/block/nbd.h: In function 'nbd_read16':
> include/block/nbd.h:383:12: error: implicit declaration of function 'be16_to_cpu' [-Werror=implicit-function-declaration]
> 383 | *val = be##bits##_to_cpu(*val); \
> | ^~
> include/block/nbd.h:387:1: note: in expansion of macro 'DEF_NBD_READ_N'
> 387 | DEF_NBD_READ_N(16) /* Defines nbd_read16(). */
> | ^~~~~~~~~~~~~~
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2023-01-19 13:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 17:53 [PATCH-for-8.0] block/nbd: Add missing <qemu/bswap.h> include Philippe Mathieu-Daudé
2022-11-25 21:13 ` Vladimir Sementsov-Ogievskiy
2023-01-12 12:00 ` Philippe Mathieu-Daudé
2023-01-16 17:35 ` Laurent Vivier
2023-01-19 13:00 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8k+2SXbXab14dFr@redhat.com \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).