From: Peter Xu <peterx@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org,
Leonardo Bras Soares Passos <lsoaresp@redhat.com>,
James Houghton <jthoughton@google.com>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH RFC 10/21] ramblock: Add ramblock_file_map()
Date: Wed, 25 Jan 2023 09:46:03 -0500 [thread overview]
Message-ID: <Y9FAq7mKJYmV4KOL@x1n> (raw)
In-Reply-To: <Y9D1SMakob6GT07e@work-vm>
On Wed, Jan 25, 2023 at 09:24:24AM +0000, Dr. David Alan Gilbert wrote:
> > > > static void *file_ram_alloc(RAMBlock *block,
> > > > int fd,
> > > > bool truncate,
> > > > off_t offset,
> > > > Error **errp)
> > > > {
> > > > - uint32_t qemu_map_flags;
> > > > void *area;
> > > >
> > > > /* Remember the offset just in case we'll need to map the range again */
> > >
> > > Note that this comment is now wrong; you need to always set that for the
> > > map call.
> >
> > This line is added in patch 7. After this patch, a ramblock should always
> > be mapped with ramblock_file_map(), so it keeps being true?
>
> With ramblock_file_map() it's not a 'just in case' any more though is
> it? This value always goes through the block-> now?
Ah yes.. Since the comment is not extremely informative, instead of
changing it, I can drop it in the previous patch when introduced.
--
Peter Xu
next prev parent reply other threads:[~2023-01-25 14:47 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 22:08 [PATCH RFC 00/21] migration: Support hugetlb doublemaps Peter Xu
2023-01-17 22:08 ` [PATCH RFC 01/21] update linux headers Peter Xu
2023-01-17 22:08 ` [PATCH RFC 02/21] util: Include osdep.h first in util/mmap-alloc.c Peter Xu
2023-01-18 12:00 ` Dr. David Alan Gilbert
2023-01-25 0:19 ` Philippe Mathieu-Daudé
2023-01-30 4:57 ` Juan Quintela
2023-01-17 22:08 ` [PATCH RFC 03/21] physmem: Add qemu_ram_is_hugetlb() Peter Xu
2023-01-18 12:02 ` Dr. David Alan Gilbert
2023-01-30 5:00 ` Juan Quintela
2023-01-17 22:08 ` [PATCH RFC 04/21] madvise: Include linux/mman.h under linux-headers/ Peter Xu
2023-01-18 12:08 ` Dr. David Alan Gilbert
2023-01-30 5:01 ` Juan Quintela
2023-01-17 22:08 ` [PATCH RFC 05/21] madvise: Add QEMU_MADV_SPLIT Peter Xu
2023-01-30 5:01 ` Juan Quintela
2023-01-17 22:08 ` [PATCH RFC 06/21] madvise: Add QEMU_MADV_COLLAPSE Peter Xu
2023-01-18 18:51 ` Dr. David Alan Gilbert
2023-01-18 20:21 ` Peter Xu
2023-01-30 5:02 ` Juan Quintela
2023-01-17 22:09 ` [PATCH RFC 07/21] ramblock: Cache file offset for file-backed ramblocks Peter Xu
2023-01-30 5:02 ` Juan Quintela
2023-01-17 22:09 ` [PATCH RFC 08/21] ramblock: Cache the length to do file mmap() on ramblocks Peter Xu
2023-01-23 18:51 ` Dr. David Alan Gilbert
2023-01-24 20:28 ` Peter Xu
2023-01-30 5:05 ` Juan Quintela
2023-01-30 22:07 ` Peter Xu
2023-01-17 22:09 ` [PATCH RFC 09/21] ramblock: Add RAM_READONLY Peter Xu
2023-01-23 19:42 ` Dr. David Alan Gilbert
2023-01-30 5:06 ` Juan Quintela
2023-01-17 22:09 ` [PATCH RFC 10/21] ramblock: Add ramblock_file_map() Peter Xu
2023-01-24 10:06 ` Dr. David Alan Gilbert
2023-01-24 20:47 ` Peter Xu
2023-01-25 9:24 ` Dr. David Alan Gilbert
2023-01-25 14:46 ` Peter Xu [this message]
2023-01-30 5:09 ` Juan Quintela
2023-01-17 22:09 ` [PATCH RFC 11/21] migration: Add hugetlb-doublemap cap Peter Xu
2023-01-24 12:45 ` Dr. David Alan Gilbert
2023-01-24 21:15 ` Peter Xu
2023-01-30 5:13 ` Juan Quintela
2023-01-17 22:09 ` [PATCH RFC 12/21] migration: Introduce page size for-migration-only Peter Xu
2023-01-24 13:20 ` Dr. David Alan Gilbert
2023-01-24 21:36 ` Peter Xu
2023-01-24 22:03 ` Peter Xu
2023-01-30 5:17 ` Juan Quintela
2023-01-17 22:09 ` [PATCH RFC 13/21] migration: Add migration_ram_pagesize_largest() Peter Xu
2023-01-24 17:34 ` Dr. David Alan Gilbert
2023-01-30 5:19 ` Juan Quintela
2023-01-17 22:09 ` [PATCH RFC 14/21] migration: Map hugetlbfs ramblocks twice, and pre-allocate Peter Xu
2023-01-25 14:25 ` Dr. David Alan Gilbert
2023-01-30 5:24 ` Juan Quintela
2023-01-30 22:35 ` Peter Xu
2023-02-01 18:53 ` Juan Quintela
2023-02-06 21:40 ` Peter Xu
2023-01-17 22:09 ` [PATCH RFC 15/21] migration: Teach qemu about minor faults and doublemap Peter Xu
2023-01-30 5:45 ` Juan Quintela
2023-01-30 22:50 ` Peter Xu
2023-02-01 18:55 ` Juan Quintela
2023-01-17 22:09 ` [PATCH RFC 16/21] migration: Enable doublemap with MADV_SPLIT Peter Xu
2023-02-01 18:59 ` Juan Quintela
2023-01-17 22:09 ` [PATCH RFC 17/21] migration: Rework ram discard logic for hugetlb double-map Peter Xu
2023-02-01 19:03 ` Juan Quintela
2023-01-17 22:09 ` [PATCH RFC 18/21] migration: Allow postcopy_register_shared_ufd() to fail Peter Xu
2023-02-01 19:09 ` Juan Quintela
2023-01-17 22:09 ` [PATCH RFC 19/21] migration: Add postcopy_mark_received() Peter Xu
2023-02-01 19:10 ` Juan Quintela
2023-01-17 22:09 ` [PATCH RFC 20/21] migration: Handle page faults using UFFDIO_CONTINUE Peter Xu
2023-02-01 19:24 ` Juan Quintela
2023-02-01 19:52 ` Juan Quintela
2023-01-17 22:09 ` [PATCH RFC 21/21] migration: Collapse huge pages again after postcopy finished Peter Xu
2023-02-01 19:49 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9FAq7mKJYmV4KOL@x1n \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=jthoughton@google.com \
--cc=lsoaresp@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).