From: Stefan Hajnoczi <stefanha@redhat.com>
To: Alexander Bulekov <alxndr@bu.edu>
Cc: qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Mauro Matteo Cascella" <mcascell@redhat.com>,
"Peter Xu" <peterx@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Bandan Das" <bsd@redhat.com>,
"Edgar E . Iglesias" <edgar.iglesias@gmail.com>,
"Darren Kenny" <darren.kenny@oracle.com>,
"Bin Meng" <bin.meng@windriver.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Jon Maloy" <jmaloy@redhat.com>, "Siqi Chen" <coc.cyqh@gmail.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Anthony Perard" <anthony.perard@citrix.com>,
"Paul Durrant" <paul@xen.org>, "Kevin Wolf" <kwolf@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>, "Amit Shah" <amit@kernel.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"John Snow" <jsnow@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Keith Busch" <kbusch@kernel.org>,
"Klaus Jensen" <its@irrelevant.dk>, "Fam Zheng" <fam@euphon.net>,
"Dmitry Fleytman" <dmitry.fleytman@gmail.com>,
"Gonglei (Arei)" <arei.gonglei@huawei.com>,
"open list:X86 Xen CPUs" <xen-devel@lists.xenproject.org>,
"open list:virtio-blk" <qemu-block@nongnu.org>,
"open list:i.MX31 (kzm)" <qemu-arm@nongnu.org>,
"open list:Old World (g3beige)" <qemu-ppc@nongnu.org>
Subject: Re: [PATCH v4 3/3] hw: replace most qemu_bh_new calls with qemu_bh_new_guarded
Date: Wed, 25 Jan 2023 17:19:49 -0500 [thread overview]
Message-ID: <Y9GrBTALs18YkSKG@fedora> (raw)
In-Reply-To: <20230119070308.321653-4-alxndr@bu.edu>
[-- Attachment #1: Type: text/plain, Size: 1569 bytes --]
On Thu, Jan 19, 2023 at 02:03:08AM -0500, Alexander Bulekov wrote:
> This protects devices from bh->mmio reentrancy issues.
>
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> ---
> hw/9pfs/xen-9p-backend.c | 4 +++-
> hw/block/dataplane/virtio-blk.c | 3 ++-
> hw/block/dataplane/xen-block.c | 5 +++--
> hw/block/virtio-blk.c | 5 +++--
> hw/char/virtio-serial-bus.c | 3 ++-
> hw/display/qxl.c | 9 ++++++---
> hw/display/virtio-gpu.c | 6 ++++--
> hw/ide/ahci.c | 3 ++-
> hw/ide/core.c | 3 ++-
> hw/misc/imx_rngc.c | 6 ++++--
> hw/misc/macio/mac_dbdma.c | 2 +-
> hw/net/virtio-net.c | 3 ++-
> hw/nvme/ctrl.c | 6 ++++--
> hw/scsi/mptsas.c | 3 ++-
> hw/scsi/scsi-bus.c | 3 ++-
> hw/scsi/vmw_pvscsi.c | 3 ++-
> hw/usb/dev-uas.c | 3 ++-
> hw/usb/hcd-dwc2.c | 3 ++-
> hw/usb/hcd-ehci.c | 3 ++-
> hw/usb/hcd-uhci.c | 2 +-
> hw/usb/host-libusb.c | 6 ++++--
> hw/usb/redirect.c | 6 ++++--
> hw/usb/xen-usb.c | 3 ++-
> hw/virtio/virtio-balloon.c | 5 +++--
> hw/virtio/virtio-crypto.c | 3 ++-
> 25 files changed, 66 insertions(+), 35 deletions(-)
Should scripts/checkpatch.pl complain when qemu_bh_new() or aio_bh_new()
are called from hw/? Adding a check is important so new instances cannot
be added accidentally in the future.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-01-25 22:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 7:03 [PATCH v4 0/3] memory: prevent dma-reentracy issues Alexander Bulekov
2023-01-19 7:03 ` [PATCH v4 1/3] " Alexander Bulekov
2023-01-25 21:12 ` Stefan Hajnoczi
2023-01-19 7:03 ` [PATCH v4 2/3] async: Add an optional reentrancy guard to the BH API Alexander Bulekov
2023-01-25 21:24 ` Stefan Hajnoczi
2023-01-26 4:18 ` Alexander Bulekov
2023-01-19 7:03 ` [PATCH v4 3/3] hw: replace most qemu_bh_new calls with qemu_bh_new_guarded Alexander Bulekov
2023-01-25 22:19 ` Stefan Hajnoczi [this message]
2023-01-25 22:19 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9GrBTALs18YkSKG@fedora \
--to=stefanha@redhat.com \
--cc=alxndr@bu.edu \
--cc=amit@kernel.org \
--cc=anthony.perard@citrix.com \
--cc=arei.gonglei@huawei.com \
--cc=berrange@redhat.com \
--cc=bin.meng@windriver.com \
--cc=bsd@redhat.com \
--cc=coc.cyqh@gmail.com \
--cc=darren.kenny@oracle.com \
--cc=david@redhat.com \
--cc=dmitry.fleytman@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=eduardo@habkost.net \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=its@irrelevant.dk \
--cc=jasowang@redhat.com \
--cc=jmaloy@redhat.com \
--cc=jsnow@redhat.com \
--cc=kbusch@kernel.org \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mcascell@redhat.com \
--cc=mst@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=thuth@redhat.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).