From: Peter Xu <peterx@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org,
Leonardo Bras Soares Passos <lsoaresp@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH 2/3] util/userfaultfd: Add uffd_open()
Date: Thu, 26 Jan 2023 10:58:02 -0500 [thread overview]
Message-ID: <Y9KjCtRex0N1uhou@x1n> (raw)
In-Reply-To: <28e8528a-3143-7e10-eca0-f16eb08043ad@linaro.org>
On Thu, Jan 26, 2023 at 12:04:35AM +0100, Philippe Mathieu-Daudé wrote:
> On 25/1/23 23:40, Peter Xu wrote:
> > Add a helper to create the uffd handle.
> >
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> > ---
> > include/qemu/userfaultfd.h | 1 +
> > migration/postcopy-ram.c | 11 +++++------
> > tests/qtest/migration-test.c | 3 ++-
> > util/userfaultfd.c | 13 +++++++++++--
> > 4 files changed, 19 insertions(+), 9 deletions(-)
> >
> > diff --git a/include/qemu/userfaultfd.h b/include/qemu/userfaultfd.h
> > index 6b74f92792..a19a05d5f7 100644
> > --- a/include/qemu/userfaultfd.h
> > +++ b/include/qemu/userfaultfd.h
> > @@ -17,6 +17,7 @@
> > #include "exec/hwaddr.h"
> > #include <linux/userfaultfd.h>
> > +int uffd_open(int flags);
>
> Preferably documenting what this function returns:
Sure thing.
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2023-01-26 15:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 22:40 [PATCH 0/3] util/userfaultfd: Support /dev/userfaultfd Peter Xu
2023-01-25 22:40 ` [PATCH 1/3] linux-headers: Update to v6.1 Peter Xu
2023-01-25 22:40 ` [PATCH 2/3] util/userfaultfd: Add uffd_open() Peter Xu
2023-01-25 23:04 ` Philippe Mathieu-Daudé
2023-01-26 15:58 ` Peter Xu [this message]
2023-01-25 22:40 ` [PATCH 3/3] util/userfaultfd: Support /dev/userfaultfd Peter Xu
2023-01-25 23:08 ` Philippe Mathieu-Daudé
2023-01-26 17:33 ` Peter Xu
2023-01-26 9:02 ` Daniel P. Berrangé
2023-01-26 9:05 ` Daniel P. Berrangé
2023-01-26 20:03 ` Peter Xu
2023-01-26 14:13 ` [PATCH 0/3] " Michal Prívozník
2023-01-26 14:15 ` Dr. David Alan Gilbert
2023-01-26 15:25 ` Peter Xu
2023-01-26 15:29 ` Michal Prívozník
2023-01-26 15:49 ` Peter Xu
2023-01-26 15:59 ` Daniel P. Berrangé
2023-01-26 17:26 ` Peter Xu
2023-01-31 19:48 ` Peter Xu
2023-01-31 20:06 ` Daniel P. Berrangé
2023-01-31 21:01 ` Peter Xu
2023-02-01 7:55 ` Michal Prívozník
2023-02-01 14:58 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9KjCtRex0N1uhou@x1n \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lsoaresp@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).