From: Stefan Hajnoczi <stefanha@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Fam Zheng <fam@euphon.net>,
Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>,
qemu-block@nongnu.org, Fiona Ebner <f.ebner@proxmox.com>
Subject: Re: [PATCH 4/4] iotests/detect-zeroes-registered-buf: add new test
Date: Mon, 30 Jan 2023 15:46:05 -0500 [thread overview]
Message-ID: <Y9gsjecmU5K6eGRe@fedora> (raw)
In-Reply-To: <20230127232548.6hofhg4tketr5ex7@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1517 bytes --]
On Fri, Jan 27, 2023 at 05:25:48PM -0600, Eric Blake wrote:
> On Thu, Jan 26, 2023 at 03:14:01PM -0500, Stefan Hajnoczi wrote:
> > This regression test demonstrates that detect-zeroes works with
> > registered buffers. Bug details:
> > https://gitlab.com/qemu-project/qemu/-/issues/1404
> >
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> > .../tests/detect-zeroes-registered-buf | 58 +++++++++++++++++++
> > .../tests/detect-zeroes-registered-buf.out | 7 +++
> > 2 files changed, 65 insertions(+)
> > create mode 100755 tests/qemu-iotests/tests/detect-zeroes-registered-buf
> > create mode 100644 tests/qemu-iotests/tests/detect-zeroes-registered-buf.out
> >
> > diff --git a/tests/qemu-iotests/tests/detect-zeroes-registered-buf b/tests/qemu-iotests/tests/detect-zeroes-registered-buf
> > new file mode 100755
> > index 0000000000..edb5f2cee5
> > --- /dev/null
> > +++ b/tests/qemu-iotests/tests/detect-zeroes-registered-buf
> > @@ -0,0 +1,58 @@
> > +#!/usr/bin/env bash
> > +# group: rw auto quick
> > +#
> > +# Check that detect-zeroes=unmap works on writes with registered I/O buffers.
> > +# This is a regression test for
> > +# https://gitlab.com/qemu-project/qemu/-/issues/1404 where I/O requests failed
> > +# unexpectedly.
> > +#
> > +# Copyright Red Hat
>
> Do you need a year or a (C) or similar?
No, this is the cool new copyright style that Red Hat legal recommends!
:)
I'll send you the details in a separate email.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2023-01-30 20:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 20:13 [PATCH 0/4] block: fix detect-zeroes= with BDRV_REQ_REGISTERED_BUF Stefan Hajnoczi
2023-01-26 20:13 ` [PATCH 1/4] " Stefan Hajnoczi
2023-01-27 8:23 ` Fiona Ebner
2023-01-26 20:13 ` [PATCH 2/4] qemu-io: use BdrvRequestFlags instead of int Stefan Hajnoczi
2023-01-27 23:18 ` Eric Blake
2023-01-26 20:14 ` [PATCH 3/4] qemu-io: add -r option to register I/O buffer Stefan Hajnoczi
2023-01-27 23:24 ` Eric Blake
2023-01-30 20:55 ` Stefan Hajnoczi
2023-01-26 20:14 ` [PATCH 4/4] iotests/detect-zeroes-registered-buf: add new test Stefan Hajnoczi
2023-01-27 23:25 ` Eric Blake
2023-01-30 20:46 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9gsjecmU5K6eGRe@fedora \
--to=stefanha@redhat.com \
--cc=eblake@redhat.com \
--cc=f.ebner@proxmox.com \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).