From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 981CCC433DB for ; Mon, 18 Jan 2021 19:29:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C95F422252 for ; Mon, 18 Jan 2021 19:29:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C95F422252 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=irrelevant.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54924 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1aDl-0007TC-SH for qemu-devel@archiver.kernel.org; Mon, 18 Jan 2021 14:29:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46334) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1a7m-0006cj-LQ; Mon, 18 Jan 2021 14:23:38 -0500 Received: from new4-smtp.messagingengine.com ([66.111.4.230]:49421) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1a7k-0000ZB-IK; Mon, 18 Jan 2021 14:23:38 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id E14B75807FD; Mon, 18 Jan 2021 14:23:34 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 18 Jan 2021 14:23:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=7DpePfuKJeDuvf3w/CejnghL5JR 53EvnlhH0MXILIc8=; b=1fAl9QH3igzrsiZ+p6HkauW9lok1Z4lmP5/NGZl9gY1 70SnAUzqy9AhmEIAwwdfjuRjVOu051xr1FkUCOPE3SQxBL1C3iwSFC/4au7e7wjm COhkM0ufhPXTZtmRalp3lvVmXyLeQWqYujFgYF2pAjf1VXMyxKCQ2zTo9z+GC+nh j8r6zhUFRqzGhUFTmvs7G3vQff1FEgFWGZu1MjGalnDpnrPXDCIK4Lif1y9drWFV VHRsow3/6+TsMAy+5v85y+kdIuablMcup1IJD6n1VnRAkQY55xpiZl5brLM0bDt9 Auej7HnCs3sRH+aiuhT5Aac7B6VMJPDVq5M8alfklNA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=7DpePf uKJeDuvf3w/CejnghL5JR53EvnlhH0MXILIc8=; b=Kk3nkzk++6DYkEJAyrELgb EiAXT/UA8CH1x+4G9bq/4DSt+yXcvUGi5zw3CsTb3avFVDuAi6mjkPhzjWQdr5Jg M4Sl7/KO0ys+jAD+zhB1wU9uvVNRRRyWLj5BJ/PCquKYKk9WMVuM0a4XcLJxgonM DB/Z76CAF9pTfV68L28030cGQbQGu583bvgLHEYOtn4yUXQoSf/0W7ewhocCqbqI WQnik0i6djB4ClkIsUKxdOgGtq/6ktK6qgTcSM0Wgql3BF8Gu6Yp9YBEJkyJJIbz WR/4TyMSwmGinaGcg6HPWa1pMVgx7BIiGo0hIntIiks+sdKs0FTzGTC1iynn0hDg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrtdekgdduvdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtdorredttdejnecuhfhrohhmpefmlhgruhhs ucflvghnshgvnhcuoehithhssehirhhrvghlvghvrghnthdrughkqeenucggtffrrghtth gvrhhnpeeuueffiefhgffgteehjeeiveeludfhteffhfehiefgheetjeeitedvtdegvdeh tdenucfkphepkedtrdduieejrdelkedrudeltdenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehithhssehirhhrvghlvghvrghnthdrughk X-ME-Proxy: Received: from apples.localdomain (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by mail.messagingengine.com (Postfix) with ESMTPA id 8DFF7108005B; Mon, 18 Jan 2021 14:23:32 -0500 (EST) Date: Mon, 18 Jan 2021 20:23:30 +0100 From: Klaus Jensen To: Minwoo Im Subject: Re: [PATCH v2 10/12] hw/block/nvme: move cmb logic to v1.4 Message-ID: References: <20210118094705.56772-1-its@irrelevant.dk> <20210118094705.56772-11-its@irrelevant.dk> <20210118125859.GH18718@localhost.localdomain> <20210118130946.GJ18718@localhost.localdomain> <20210118131205.GK18718@localhost.localdomain> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="V507rhvjKIZUG5oW" Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=66.111.4.230; envelope-from=its@irrelevant.dk; helo=new4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Kevin Wolf , Padmakar Kalghatgi , qemu-block@nongnu.org, Klaus Jensen , qemu-devel@nongnu.org, Max Reitz , Stefan Hajnoczi , Keith Busch Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --V507rhvjKIZUG5oW Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Jan 18 14:22, Klaus Jensen wrote: > On Jan 18 22:12, Minwoo Im wrote: > > On 21-01-18 14:10:50, Klaus Jensen wrote: > > > On Jan 18 22:09, Minwoo Im wrote: > > > > > > Yes, CMB in v1.4 is not backward-compatible, but is it okay to = move onto > > > > > > the CMB v1.4 from v1.3 without supporting the v1.3 usage on thi= s device > > > > > > model? > > > > >=20 > > > > > Next patch moves to v1.4. I wanted to split it because the "bump"= patch > > > > > also adds a couple of other v1.4 requires fields. But I understan= d that > > > > > this is slightly wrong. > > > >=20 > > > > Sorry, I meant I'd like to have CMB for v1.3 support along with the= v1.4 > > > > support in this device model separately. Maybe I missed the linux-= nvme > > > > mailing list for CMB v1.4, but is there no plan to keep supportin C= MB > > > > v1.3 in NVMe driver? > > >=20 > > > I posted a patch on linux-nvme for v1.4 support in the kernel. It will > > > support both the v1.3 and v1.4 behavior :) > >=20 > > Then, can we maintain CMB v1.3 also in QEMU also along with v1.4 ? :) >=20 > My first version of this patch actually included compatibility support > for v1.3 ("legacy cmb"), but Keith suggested we just drop that and keep > this device compliant. >=20 > What we could do is allow the spec version to be chosen with a > parameter? Uhm. Maybe not. I gave this some more thought. Adding a device parameter to choose the specification version requires us to maintain QEMU "compat" properties across different QEMU version. I'm not sure we want that for something like this. Maybe the best course of action actually *is* an 'x-legacy-cmb' parameter. --V507rhvjKIZUG5oW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmAF4C8ACgkQTeGvMW1P DelilQgAlJaHlw9ohBmvhDRJ78OeyQaQ+PTuVr3AXcW01gpPsntFnaltdjHqLIxy Lp5GOWtamLruiI/uyENt7fXth2PZoZxsH5Weai/W9dcNEbuspB8N7stvj0zdMUZw +tCgBL1AFAzD0SVn4+Iu9+lkpo+LYJfWXJuMh2fVhVQob4epUA/O8Ey9+mnasY80 LPl2HXbcI0YCATL4qG+j80cNqpzGOKclakj7k5WXq0XyBquuQWKNPTCendiMpLel +ls2V2Y2vHHx/aUYFi9Nj5ck6wHE1YBWUOb2ByzqagF575IIY+y/iCBmwSWg/MDk ra4lTMj/AfE3xfrknONBxVzOf6R8Ew== =SPyw -----END PGP SIGNATURE----- --V507rhvjKIZUG5oW--