From: Klaus Jensen <its@irrelevant.dk>
To: qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Klaus Jensen <k.jensen@samsung.com>,
Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH v5 5/5] hw/block/nvme: add simple copy command
Date: Mon, 1 Feb 2021 22:45:05 +0100 [thread overview]
Message-ID: <YBh2YSkMwuhGbUUG@apples.localdomain> (raw)
In-Reply-To: <20210129091541.566330-6-its@irrelevant.dk>
[-- Attachment #1: Type: text/plain, Size: 2062 bytes --]
On Jan 29 10:15, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> Add support for TP 4065a ("Simple Copy Command"), v2020.05.04
> ("Ratified").
>
> The implementation uses a bounce buffer to first read in the source
> logical blocks, then issue a write of that bounce buffer. The default
> maximum number of source logical blocks is 128, translating to 512 KiB
> for 4k logical blocks which aligns with the default value of MDTS.
>
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> ---
> hw/block/nvme-ns.h | 4 +
> hw/block/nvme.h | 1 +
> hw/block/nvme-ns.c | 8 ++
> hw/block/nvme.c | 253 +++++++++++++++++++++++++++++++++++++++++-
> hw/block/trace-events | 7 ++
> 5 files changed, 272 insertions(+), 1 deletion(-)
>
> diff --git a/hw/block/trace-events b/hw/block/trace-events
> index c083000b8c1f..b26866ba4338 100644
> --- a/hw/block/trace-events
> +++ b/hw/block/trace-events
> @@ -43,12 +43,18 @@ pci_nvme_admin_cmd(uint16_t cid, uint16_t sqid, uint8_t opcode, const char *opna
> pci_nvme_read(uint16_t cid, uint32_t nsid, uint32_t nlb, uint64_t count, uint64_t lba) "cid %"PRIu16" nsid %"PRIu32" nlb %"PRIu32" count %"PRIu64" lba 0x%"PRIx64""
> pci_nvme_write(uint16_t cid, const char *verb, uint32_t nsid, uint32_t nlb, uint64_t count, uint64_t lba) "cid %"PRIu16" opname '%s' nsid %"PRIu32" nlb %"PRIu32" count %"PRIu64" lba 0x%"PRIx64""
> pci_nvme_rw_cb(uint16_t cid, const char *blkname) "cid %"PRIu16" blk '%s'"
> +pci_nvme_copy(uint16_t cid, uint32_t nsid, uint16_t nr, uint8_t format) "cid %"PRIu16" nsid %"PRIu32" nr %"PRIu16" format 0x%"PRIx8""
> +pci_nvme_copy_source_range(uint64_t slba, uint32_t nlb) "slba 0x%"PRIx64" nlb %"PRIu32""
> +pci_nvme_copy_in_complete(uint16_t cid) "cid %"PRIu16""
> +pci_nvme_copy_cb(uint16_t cid) "cid %"PRIu16""
> +pci_nvme_write_zeroes(uint16_t cid, uint32_t nsid, uint64_t slba, uint32_t nlb) "cid %"PRIu16" nsid %"PRIu32" slba %"PRIu64" nlb %"PRIu32""
Woops. An old trace event ended up in there when rebasing.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-02-01 21:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 9:15 [PATCH v5 0/5] hw/block/nvme: add simple copy command Klaus Jensen
2021-01-29 9:15 ` [PATCH v5 1/5] hw/block/nvme: remove unused parameter in check zone write Klaus Jensen
2021-01-29 9:15 ` [PATCH v5 2/5] hw/block/nvme: refactor zone resource management Klaus Jensen
2021-01-29 9:15 ` [PATCH v5 3/5] hw/block/nvme: pull write pointer advancement to separate function Klaus Jensen
2021-01-29 9:15 ` [PATCH v5 4/5] nvme: updated shared header for copy command Klaus Jensen
2021-02-03 17:21 ` Keith Busch
2021-02-03 18:55 ` Klaus Jensen
2021-01-29 9:15 ` [PATCH v5 5/5] hw/block/nvme: add simple " Klaus Jensen
2021-02-01 21:45 ` Klaus Jensen [this message]
2021-02-03 17:27 ` [PATCH v5 0/5] " Keith Busch
2021-02-03 18:57 ` Klaus Jensen
2021-02-05 8:50 ` Klaus Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBh2YSkMwuhGbUUG@apples.localdomain \
--to=its@irrelevant.dk \
--cc=fam@euphon.net \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).