qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Thomas Huth" <thuth@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH] gitlab-ci: Remove unused container images
Date: Fri, 19 Feb 2021 12:08:31 +0000	[thread overview]
Message-ID: <YC+qPxXExZgXS/qO@redhat.com> (raw)
In-Reply-To: <ca4a7cf3-c0b8-2074-d288-d402e5900cf9@amsat.org>

On Fri, Feb 19, 2021 at 01:00:21PM +0100, Philippe Mathieu-Daudé wrote:
> On 2/19/21 12:09 PM, Thomas Huth wrote:
> > We're building a lot of containers in the gitlab-CI that we never use.
> > This takes away network bandwidth and CPU time from other jobs for no
> > use, so let's remove them for now. The individual containers could be
> > re-added later when we really need them.
> > 
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> >  .gitlab-ci.d/containers.yml | 92 -------------------------------------
> >  1 file changed, 92 deletions(-)
> 
> I'm not enthusiast with this patch because I use various in this list
> from time to time for testing or cross build/disas binaries. Not having
> these containers used mainstream probably show the failure of the
> project to add good testing coverage on these targets. Most of them are
> for hobbyist with little time. Removing them will make it even harder
> to add tests. Can't we keep them disabled? Or put them in manual mode?
> 
> Why is the CI rebuilding them, shouldn't them be cached or pulled from
> the registry?

Even using the cache still takes a few minutes of execution time.

> Maybe this show having all them in the same containers.yml file is not
> good enough? Any suggestion for splitting it, so lowly used containers
> don't get rebuild every time another often used one change the YAML
> file?

IMHO they just need to be marked as manual triggered jobs.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2021-02-19 12:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-19 11:09 [PATCH] gitlab-ci: Remove unused container images Thomas Huth
2021-02-19 11:40 ` Daniel P. Berrangé
2021-02-19 12:00 ` Philippe Mathieu-Daudé
2021-02-19 12:08   ` Daniel P. Berrangé [this message]
2021-02-19 13:10   ` Thomas Huth
2021-02-19 13:41     ` Philippe Mathieu-Daudé
2021-02-20 21:11     ` Alex Bennée
2021-02-20 21:10 ` Alex Bennée
2021-02-21  8:39   ` Philippe Mathieu-Daudé
2021-02-22  5:31   ` Thomas Huth
2021-02-22  8:44     ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YC+qPxXExZgXS/qO@redhat.com \
    --to=berrange@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).