From: Klaus Jensen <its@irrelevant.dk>
To: Keith Busch <kbusch@kernel.org>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <fam@euphon.net>,
qemu-block@nongnu.org, Klaus Jensen <k.jensen@samsung.com>,
Gollu Appalanaidu <anaidu.gollu@samsung.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH 0/2] hw/block/nvme: add support for telemetry log pages
Date: Mon, 8 Feb 2021 18:47:01 +0100 [thread overview]
Message-ID: <YCF5FbyRyyieFhiz@apples.localdomain> (raw)
In-Reply-To: <20210208154008.GB16360@redsun51.ssa.fujisawa.hgst.com>
[-- Attachment #1: Type: text/plain, Size: 513 bytes --]
On Feb 9 00:40, Keith Busch wrote:
> On Mon, Feb 08, 2021 at 03:10:10PM +0100, Klaus Jensen wrote:
> > From: Klaus Jensen <k.jensen@samsung.com>
> >
> > This adds support for the telemetry log pages and fixes up the
> > controller IEEE OUI.
>
> Patch 1 is fine.
>
> I don't see the point for patch 2. We don't need an empty implementation
> for every optional spec feature just because it's there. The features
> we do implement ought to provide something useful, yeah?
Alright, point taken :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-02-08 21:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 14:10 [PATCH 0/2] hw/block/nvme: add support for telemetry log pages Klaus Jensen
2021-02-08 14:10 ` [PATCH 1/2] hw/block/nvme: use locally assigned QEMU IEEE OUI Klaus Jensen
2021-02-08 18:56 ` Philippe Mathieu-Daudé
2021-02-08 19:01 ` Klaus Jensen
2021-02-08 14:10 ` [PATCH 2/2] hw/block/nvme: add nvme telemetry log support Klaus Jensen
2021-02-08 15:40 ` [PATCH 0/2] hw/block/nvme: add support for telemetry log pages Keith Busch
2021-02-08 17:47 ` Klaus Jensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCF5FbyRyyieFhiz@apples.localdomain \
--to=its@irrelevant.dk \
--cc=anaidu.gollu@samsung.com \
--cc=fam@euphon.net \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).