From: Klaus Jensen <its@irrelevant.dk>
To: Bin Meng <bmeng.cn@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Qemu-block <qemu-block@nongnu.org>,
Bin Meng <bin.meng@windriver.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
Max Reitz <mreitz@redhat.com>, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] hw/block: nvme: Fix a build error in nvme_process_sq()
Date: Wed, 10 Feb 2021 11:31:32 +0100 [thread overview]
Message-ID: <YCO2BMwhJE/yoNav@apples.localdomain> (raw)
In-Reply-To: <CAEUhbmWB2PCYbe2Dd2Ui8C-=dE_FDjEMApDf1GkXzJe2LBQkRQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 864 bytes --]
On Feb 10 18:24, Bin Meng wrote:
> On Wed, Feb 10, 2021 at 6:23 PM Klaus Jensen <its@irrelevant.dk> wrote:
> >
> > On Feb 10 18:15, Bin Meng wrote:
> > > On Wed, Feb 10, 2021 at 5:54 PM Bin Meng <bmeng.cn@gmail.com> wrote:
> > > >
> > > > From: Bin Meng <bin.meng@windriver.com>
> > > >
> > > > Current QEMU HEAD nvme.c does not compile:
> > > >
> > > > hw/block/nvme.c: In function ‘nvme_process_sq’:
> > >
> > > Not sure why compiler reports this error happens in nvme_process_sq()?
> > >
> >
> > Yeah that is kinda wierd. Also, this went through the full CI suite.
> > What compiler is this?
> >
>
> Yes it's quite strange.
>
> I am using the default GCC 5.4 on a Ubuntu 16.04 host.
>
Alright. I'm actually not sure why newer compilers does not report this.
The warning looks reasonable.
I'll queue up your patch, Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-02-10 10:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 9:54 [PATCH] hw/block: nvme: Fix a build error in nvme_process_sq() Bin Meng
2021-02-10 10:15 ` Bin Meng
2021-02-10 10:23 ` Klaus Jensen
2021-02-10 10:24 ` Bin Meng
2021-02-10 10:31 ` Klaus Jensen [this message]
2021-02-10 11:01 ` Peter Maydell
2021-02-10 11:37 ` Klaus Jensen
2021-02-10 13:31 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCO2BMwhJE/yoNav@apples.localdomain \
--to=its@irrelevant.dk \
--cc=bin.meng@windriver.com \
--cc=bmeng.cn@gmail.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).