From: Klaus Jensen <its@irrelevant.dk>
To: Minwoo Im <minwoo.im.dev@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
qemu-devel@nongnu.org, Keith Busch <kbusch@kernel.org>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [RFC PATCH 2/3] hw/block/nvme: support command retry delay
Date: Wed, 10 Feb 2021 21:37:08 +0100 [thread overview]
Message-ID: <YCRD9Ojsx0f9y0Ds@apples.localdomain> (raw)
In-Reply-To: <20210210195252.19339-3-minwoo.im.dev@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]
On Feb 11 04:52, Minwoo Im wrote:
> Set CRDT1(Command Retry Delay Time 1) in the Identify controller data
> structure to milliseconds units of 100ms by the given value of
> 'cmd-retry-delay' parameter which is newly added. If
> cmd-retry-delay=1000, it will be set CRDT1 to 10. This patch only
> considers the CRDT1 without CRDT2 and 3 for the simplicity.
>
> This patch also introduced set/get feature command handler for Host
> Behavior feature (16h). In this feature, ACRE(Advanced Command Retry
> Enable) will be set by the host based on the Identify controller data
> structure, especially by CRDTs.
>
> If 'cmd-retry-delay' is not given, the default value will be -1 which is
> CRDT will not be configured at all and ACRE will not be supported. In
> this case, we just set NVME_DNR to the error CQ entry just like we used
> to. If it's given to positive value, then ACRE will be supported by the
> device.
>
> Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
> ---
LGTM.
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-02-10 20:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 19:52 [RFC PATCH 0/3] support command retry Minwoo Im
2021-02-10 19:52 ` [RFC PATCH 1/3] hw/block/nvme: set NVME_DNR in a single place Minwoo Im
2021-02-10 20:19 ` Klaus Jensen
2021-02-11 3:40 ` Minwoo Im
2021-02-10 19:52 ` [RFC PATCH 2/3] hw/block/nvme: support command retry delay Minwoo Im
2021-02-10 20:37 ` Klaus Jensen [this message]
2021-02-10 19:52 ` [RFC PATCH 3/3] hw/block/nvme: add nvme_inject_state HMP command Minwoo Im
2021-02-10 20:33 ` Klaus Jensen
2021-02-11 3:23 ` Minwoo Im
2021-02-11 10:02 ` Dr. David Alan Gilbert
2021-02-11 3:00 ` Keith Busch
2021-02-11 3:38 ` Minwoo Im
2021-02-11 4:24 ` Keith Busch
2021-02-11 4:40 ` Warner Losh
2021-02-11 6:06 ` Minwoo Im
2021-02-11 7:26 ` Klaus Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCRD9Ojsx0f9y0Ds@apples.localdomain \
--to=its@irrelevant.dk \
--cc=dgilbert@redhat.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=minwoo.im.dev@gmail.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).