From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: Jiang Liu <gerry@linux.alibaba.com>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v2] vhost-user.rst: add clarifying language about protocol negotiation
Date: Wed, 3 Mar 2021 17:56:43 +0000 [thread overview]
Message-ID: <YD/N23Ov4PbVoat3@stefanha-x1.localdomain> (raw)
In-Reply-To: <20210303145011.14547-1-alex.bennee@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 771 bytes --]
On Wed, Mar 03, 2021 at 02:50:11PM +0000, Alex Bennée wrote:
> Make the language about feature negotiation explicitly clear about the
> handling of the VHOST_USER_F_PROTOCOL_FEATURES feature bit. Try and
> avoid the sort of bug introduced in vhost.rs REPLY_ACK processing:
>
> https://github.com/rust-vmm/vhost/pull/24
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Jiang Liu <gerry@linux.alibaba.com>
> Message-Id: <20210226111619.21178-1-alex.bennee@linaro.org>
>
> ---
> v2
> - use Stefan's suggested wording
> - Be super explicit in the message descriptions
> ---
> docs/interop/vhost-user.rst | 18 ++++++++++++++++--
> 1 file changed, 16 insertions(+), 2 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-03-03 17:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 14:50 [PATCH v2] vhost-user.rst: add clarifying language about protocol negotiation Alex Bennée
2021-03-03 17:56 ` Stefan Hajnoczi [this message]
2021-03-03 22:01 ` Michael S. Tsirkin
2021-03-04 11:00 ` Alex Bennée
2021-03-04 17:23 ` Stefan Hajnoczi
2021-03-04 18:11 ` Alex Bennée
2021-03-05 17:43 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YD/N23Ov4PbVoat3@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=gerry@linux.alibaba.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).