From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56CCFC433E0 for ; Wed, 3 Mar 2021 18:12:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7F1E64E6F for ; Wed, 3 Mar 2021 18:12:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7F1E64E6F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40306 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHVzU-0008TY-HX for qemu-devel@archiver.kernel.org; Wed, 03 Mar 2021 13:12:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHVyY-0007iS-M7 for qemu-devel@nongnu.org; Wed, 03 Mar 2021 13:11:58 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:47356) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lHVyV-0005X3-QZ for qemu-devel@nongnu.org; Wed, 03 Mar 2021 13:11:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614795115; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=LRDGv0lc35KuNxRZKgidrWzcRgfvxC+rC/ZoMzeQGto=; b=VCtO9r+9ty4jljBtcYeCWPO7lDLAqv9Zc/n1iiUwQik024Ao70Wr/ST91sMLH3DvXjFqXR t2/v3QczYKQXmKIWPTgBHEbn1bKbAVK7K7xsBdX8lnYjcLS1d4OBek+Im8lQprQJJYyvBC N5afLTwq33gK42jDObRWqo4/ARiI+Sk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-452-2NvlZLHDMQOY5859R_R9AQ-1; Wed, 03 Mar 2021 13:11:47 -0500 X-MC-Unique: 2NvlZLHDMQOY5859R_R9AQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A5985107ACF4; Wed, 3 Mar 2021 18:11:46 +0000 (UTC) Received: from redhat.com (ovpn-115-145.ams2.redhat.com [10.36.115.145]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2068660BFA; Wed, 3 Mar 2021 18:11:44 +0000 (UTC) Date: Wed, 3 Mar 2021 18:11:41 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Doug Evans Subject: Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse Message-ID: References: <20210228213957.xkc4cceh5o6rgd5n@begin> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.0.5 (2021-01-21) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: QEMU Developers , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Samuel Thibault , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Mar 03, 2021 at 10:06:50AM -0800, Doug Evans wrote: > On Sun, Feb 28, 2021 at 1:40 PM Samuel Thibault > wrote: > > > [...] > > > > > + Examples: > > > + hostfwd_add net0 tcp:127.0.0.1:10022-:22 > > > + hostfwd_add net0 tcp:[::1]:10022-[fe80::1:2:3:4]:22 > > > > Yep, that looks good to me. > > > > > > Daniel, you wanted me to use inet_parse(). > Is the above syntax ok with you? > You must have had some expectation that at least some of > the various flags that inet_parse() recognizes would be needed here. It feels like the ,ipv4=on|off,ipv6=on|off flags are relevant here, especially in the empty address case. eg tcp::10022 - attempt to listen on both ipv4 + ipv6 tcp::10022,ipv4=off - listen on default address, but only for ipv6 tcp::10022,ipv6=off - listen on default address, but only for ipv4 Basically this ends up bringing the hostfwd stuff into alignment with the way other backends deal with this Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|