qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Fam Zheng" <fam@euphon.net>, "Thomas Huth" <thuth@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	qemu-devel@nongnu.org,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Richard W . M . Jones" <rjones@redhat.com>,
	"Bin Meng" <bmeng.cn@gmail.com>,
	"Laszlo Ersek" <lersek@redhat.com>
Subject: Re: [PATCH 2/3] docker: EDK2 build job depends on EDK2 container
Date: Wed, 3 Mar 2021 13:17:08 +0000	[thread overview]
Message-ID: <YD+MVPSuA5p0bEN1@redhat.com> (raw)
In-Reply-To: <20210303130646.1494015-3-philmd@redhat.com>

On Wed, Mar 03, 2021 at 02:06:45PM +0100, Philippe Mathieu-Daudé wrote:
> Add missing dependency build-edk2 -> docker-edk2.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  .gitlab-ci.d/edk2.yml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.gitlab-ci.d/edk2.yml b/.gitlab-ci.d/edk2.yml
> index e1e04524166..ba7280605c4 100644
> --- a/.gitlab-ci.d/edk2.yml
> +++ b/.gitlab-ci.d/edk2.yml
> @@ -25,6 +25,7 @@ docker-edk2:
>  
>  build-edk2:
>   stage: build
> + needs: ['docker-edk2']
>   rules: # Only run this job when ...
>   - changes: # ... roms/edk2/ is modified (submodule updated)
>     - roms/edk2/*

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2021-03-03 13:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-03 13:06 [PATCH 0/3] gitlab: Add missing job -> container dependencies Philippe Mathieu-Daudé
2021-03-03 13:06 ` [PATCH 1/3] docker: Alpine build job depends on Alpine container Philippe Mathieu-Daudé
2021-03-03 13:16   ` Daniel P. Berrangé
2021-03-03 14:49   ` Willian Rampazzo
2021-03-03 13:06 ` [PATCH 2/3] docker: EDK2 build job depends on EDK2 container Philippe Mathieu-Daudé
2021-03-03 13:17   ` Daniel P. Berrangé [this message]
2021-03-03 14:12   ` Laszlo Ersek
2021-03-03 14:48   ` Willian Rampazzo
2021-03-03 13:06 ` [PATCH 3/3] docker: OpenSBI build job depends on OpenSBI container Philippe Mathieu-Daudé
2021-03-03 13:17   ` Daniel P. Berrangé
2021-03-03 14:50   ` Willian Rampazzo
2021-03-03 17:55 ` [PATCH 0/3] gitlab: Add missing job -> container dependencies Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YD+MVPSuA5p0bEN1@redhat.com \
    --to=berrange@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=bmeng.cn@gmail.com \
    --cc=fam@euphon.net \
    --cc=lersek@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).