* [PATCH 1/3] docker: Alpine build job depends on Alpine container
2021-03-03 13:06 [PATCH 0/3] gitlab: Add missing job -> container dependencies Philippe Mathieu-Daudé
@ 2021-03-03 13:06 ` Philippe Mathieu-Daudé
2021-03-03 13:16 ` Daniel P. Berrangé
2021-03-03 14:49 ` Willian Rampazzo
2021-03-03 13:06 ` [PATCH 2/3] docker: EDK2 build job depends on EDK2 container Philippe Mathieu-Daudé
` (2 subsequent siblings)
3 siblings, 2 replies; 12+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-03-03 13:06 UTC (permalink / raw)
To: Daniel P . Berrange, qemu-devel
Cc: Fam Zheng, Thomas Huth, Philippe Mathieu-Daudé,
Richard W . M . Jones, Alex Bennée,
Wainer dos Santos Moschetta, Bin Meng, Laszlo Ersek
Add missing dependency build-system-alpine -> amd64-alpine-container.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
.gitlab-ci.yml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 8b6d495288d..84eb4b0e5f0 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -76,6 +76,8 @@ include:
build-system-alpine:
<<: *native_build_job_definition
+ needs:
+ - job: amd64-alpine-container
variables:
IMAGE: alpine
TARGETS: aarch64-softmmu alpha-softmmu cris-softmmu hppa-softmmu
--
2.26.2
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 1/3] docker: Alpine build job depends on Alpine container
2021-03-03 13:06 ` [PATCH 1/3] docker: Alpine build job depends on Alpine container Philippe Mathieu-Daudé
@ 2021-03-03 13:16 ` Daniel P. Berrangé
2021-03-03 14:49 ` Willian Rampazzo
1 sibling, 0 replies; 12+ messages in thread
From: Daniel P. Berrangé @ 2021-03-03 13:16 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Fam Zheng, Thomas Huth, Alex Bennée, qemu-devel,
Wainer dos Santos Moschetta, Richard W . M . Jones, Bin Meng,
Laszlo Ersek
On Wed, Mar 03, 2021 at 02:06:44PM +0100, Philippe Mathieu-Daudé wrote:
> Add missing dependency build-system-alpine -> amd64-alpine-container.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> .gitlab-ci.yml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 8b6d495288d..84eb4b0e5f0 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -76,6 +76,8 @@ include:
>
> build-system-alpine:
> <<: *native_build_job_definition
> + needs:
> + - job: amd64-alpine-container
> variables:
> IMAGE: alpine
> TARGETS: aarch64-softmmu alpha-softmmu cris-softmmu hppa-softmmu
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] docker: Alpine build job depends on Alpine container
2021-03-03 13:06 ` [PATCH 1/3] docker: Alpine build job depends on Alpine container Philippe Mathieu-Daudé
2021-03-03 13:16 ` Daniel P. Berrangé
@ 2021-03-03 14:49 ` Willian Rampazzo
1 sibling, 0 replies; 12+ messages in thread
From: Willian Rampazzo @ 2021-03-03 14:49 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Fam Zheng, Thomas Huth, Daniel P . Berrange, Laszlo Ersek,
qemu-devel, Wainer dos Santos Moschetta, Richard W . M . Jones,
Bin Meng, Alex Bennée
On Wed, Mar 3, 2021 at 10:08 AM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
>
> Add missing dependency build-system-alpine -> amd64-alpine-container.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> .gitlab-ci.yml | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 2/3] docker: EDK2 build job depends on EDK2 container
2021-03-03 13:06 [PATCH 0/3] gitlab: Add missing job -> container dependencies Philippe Mathieu-Daudé
2021-03-03 13:06 ` [PATCH 1/3] docker: Alpine build job depends on Alpine container Philippe Mathieu-Daudé
@ 2021-03-03 13:06 ` Philippe Mathieu-Daudé
2021-03-03 13:17 ` Daniel P. Berrangé
` (2 more replies)
2021-03-03 13:06 ` [PATCH 3/3] docker: OpenSBI build job depends on OpenSBI container Philippe Mathieu-Daudé
2021-03-03 17:55 ` [PATCH 0/3] gitlab: Add missing job -> container dependencies Thomas Huth
3 siblings, 3 replies; 12+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-03-03 13:06 UTC (permalink / raw)
To: Daniel P . Berrange, qemu-devel
Cc: Fam Zheng, Thomas Huth, Philippe Mathieu-Daudé,
Richard W . M . Jones, Alex Bennée,
Wainer dos Santos Moschetta, Bin Meng, Laszlo Ersek
Add missing dependency build-edk2 -> docker-edk2.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
.gitlab-ci.d/edk2.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitlab-ci.d/edk2.yml b/.gitlab-ci.d/edk2.yml
index e1e04524166..ba7280605c4 100644
--- a/.gitlab-ci.d/edk2.yml
+++ b/.gitlab-ci.d/edk2.yml
@@ -25,6 +25,7 @@ docker-edk2:
build-edk2:
stage: build
+ needs: ['docker-edk2']
rules: # Only run this job when ...
- changes: # ... roms/edk2/ is modified (submodule updated)
- roms/edk2/*
--
2.26.2
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 2/3] docker: EDK2 build job depends on EDK2 container
2021-03-03 13:06 ` [PATCH 2/3] docker: EDK2 build job depends on EDK2 container Philippe Mathieu-Daudé
@ 2021-03-03 13:17 ` Daniel P. Berrangé
2021-03-03 14:12 ` Laszlo Ersek
2021-03-03 14:48 ` Willian Rampazzo
2 siblings, 0 replies; 12+ messages in thread
From: Daniel P. Berrangé @ 2021-03-03 13:17 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Fam Zheng, Thomas Huth, Alex Bennée, qemu-devel,
Wainer dos Santos Moschetta, Richard W . M . Jones, Bin Meng,
Laszlo Ersek
On Wed, Mar 03, 2021 at 02:06:45PM +0100, Philippe Mathieu-Daudé wrote:
> Add missing dependency build-edk2 -> docker-edk2.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> .gitlab-ci.d/edk2.yml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.gitlab-ci.d/edk2.yml b/.gitlab-ci.d/edk2.yml
> index e1e04524166..ba7280605c4 100644
> --- a/.gitlab-ci.d/edk2.yml
> +++ b/.gitlab-ci.d/edk2.yml
> @@ -25,6 +25,7 @@ docker-edk2:
>
> build-edk2:
> stage: build
> + needs: ['docker-edk2']
> rules: # Only run this job when ...
> - changes: # ... roms/edk2/ is modified (submodule updated)
> - roms/edk2/*
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/3] docker: EDK2 build job depends on EDK2 container
2021-03-03 13:06 ` [PATCH 2/3] docker: EDK2 build job depends on EDK2 container Philippe Mathieu-Daudé
2021-03-03 13:17 ` Daniel P. Berrangé
@ 2021-03-03 14:12 ` Laszlo Ersek
2021-03-03 14:48 ` Willian Rampazzo
2 siblings, 0 replies; 12+ messages in thread
From: Laszlo Ersek @ 2021-03-03 14:12 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Daniel P . Berrange, qemu-devel
Cc: Fam Zheng, Thomas Huth, Richard W . M . Jones,
Wainer dos Santos Moschetta, Bin Meng, Alex Bennée
On 03/03/21 14:06, Philippe Mathieu-Daudé wrote:
> Add missing dependency build-edk2 -> docker-edk2.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> .gitlab-ci.d/edk2.yml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.gitlab-ci.d/edk2.yml b/.gitlab-ci.d/edk2.yml
> index e1e04524166..ba7280605c4 100644
> --- a/.gitlab-ci.d/edk2.yml
> +++ b/.gitlab-ci.d/edk2.yml
> @@ -25,6 +25,7 @@ docker-edk2:
>
> build-edk2:
> stage: build
> + needs: ['docker-edk2']
> rules: # Only run this job when ...
> - changes: # ... roms/edk2/ is modified (submodule updated)
> - roms/edk2/*
>
Acked-by: Laszlo Ersek <lersek@redhat.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/3] docker: EDK2 build job depends on EDK2 container
2021-03-03 13:06 ` [PATCH 2/3] docker: EDK2 build job depends on EDK2 container Philippe Mathieu-Daudé
2021-03-03 13:17 ` Daniel P. Berrangé
2021-03-03 14:12 ` Laszlo Ersek
@ 2021-03-03 14:48 ` Willian Rampazzo
2 siblings, 0 replies; 12+ messages in thread
From: Willian Rampazzo @ 2021-03-03 14:48 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Fam Zheng, Thomas Huth, Daniel P . Berrange, Laszlo Ersek,
qemu-devel, Wainer dos Santos Moschetta, Richard W . M . Jones,
Bin Meng, Alex Bennée
On Wed, Mar 3, 2021 at 10:10 AM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
>
> Add missing dependency build-edk2 -> docker-edk2.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> .gitlab-ci.d/edk2.yml | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 3/3] docker: OpenSBI build job depends on OpenSBI container
2021-03-03 13:06 [PATCH 0/3] gitlab: Add missing job -> container dependencies Philippe Mathieu-Daudé
2021-03-03 13:06 ` [PATCH 1/3] docker: Alpine build job depends on Alpine container Philippe Mathieu-Daudé
2021-03-03 13:06 ` [PATCH 2/3] docker: EDK2 build job depends on EDK2 container Philippe Mathieu-Daudé
@ 2021-03-03 13:06 ` Philippe Mathieu-Daudé
2021-03-03 13:17 ` Daniel P. Berrangé
2021-03-03 14:50 ` Willian Rampazzo
2021-03-03 17:55 ` [PATCH 0/3] gitlab: Add missing job -> container dependencies Thomas Huth
3 siblings, 2 replies; 12+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-03-03 13:06 UTC (permalink / raw)
To: Daniel P . Berrange, qemu-devel
Cc: Fam Zheng, Thomas Huth, Philippe Mathieu-Daudé,
Richard W . M . Jones, Alex Bennée,
Wainer dos Santos Moschetta, Bin Meng, Laszlo Ersek
Add missing dependency build-opensbi -> docker-opensbi.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
.gitlab-ci.d/opensbi.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitlab-ci.d/opensbi.yml b/.gitlab-ci.d/opensbi.yml
index 5b13047e2ab..f66cd1d9089 100644
--- a/.gitlab-ci.d/opensbi.yml
+++ b/.gitlab-ci.d/opensbi.yml
@@ -25,6 +25,7 @@ docker-opensbi:
build-opensbi:
stage: build
+ needs: ['docker-opensbi']
rules: # Only run this job when ...
- changes: # ... roms/opensbi/ is modified (submodule updated)
- roms/opensbi/*
--
2.26.2
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 3/3] docker: OpenSBI build job depends on OpenSBI container
2021-03-03 13:06 ` [PATCH 3/3] docker: OpenSBI build job depends on OpenSBI container Philippe Mathieu-Daudé
@ 2021-03-03 13:17 ` Daniel P. Berrangé
2021-03-03 14:50 ` Willian Rampazzo
1 sibling, 0 replies; 12+ messages in thread
From: Daniel P. Berrangé @ 2021-03-03 13:17 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Fam Zheng, Thomas Huth, Alex Bennée, qemu-devel,
Wainer dos Santos Moschetta, Richard W . M . Jones, Bin Meng,
Laszlo Ersek
On Wed, Mar 03, 2021 at 02:06:46PM +0100, Philippe Mathieu-Daudé wrote:
> Add missing dependency build-opensbi -> docker-opensbi.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> .gitlab-ci.d/opensbi.yml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.gitlab-ci.d/opensbi.yml b/.gitlab-ci.d/opensbi.yml
> index 5b13047e2ab..f66cd1d9089 100644
> --- a/.gitlab-ci.d/opensbi.yml
> +++ b/.gitlab-ci.d/opensbi.yml
> @@ -25,6 +25,7 @@ docker-opensbi:
>
> build-opensbi:
> stage: build
> + needs: ['docker-opensbi']
> rules: # Only run this job when ...
> - changes: # ... roms/opensbi/ is modified (submodule updated)
> - roms/opensbi/*
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 3/3] docker: OpenSBI build job depends on OpenSBI container
2021-03-03 13:06 ` [PATCH 3/3] docker: OpenSBI build job depends on OpenSBI container Philippe Mathieu-Daudé
2021-03-03 13:17 ` Daniel P. Berrangé
@ 2021-03-03 14:50 ` Willian Rampazzo
1 sibling, 0 replies; 12+ messages in thread
From: Willian Rampazzo @ 2021-03-03 14:50 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Fam Zheng, Thomas Huth, Daniel P . Berrange, Laszlo Ersek,
qemu-devel, Wainer dos Santos Moschetta, Richard W . M . Jones,
Bin Meng, Alex Bennée
On Wed, Mar 3, 2021 at 10:12 AM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
>
> Add missing dependency build-opensbi -> docker-opensbi.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> .gitlab-ci.d/opensbi.yml | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/3] gitlab: Add missing job -> container dependencies
2021-03-03 13:06 [PATCH 0/3] gitlab: Add missing job -> container dependencies Philippe Mathieu-Daudé
` (2 preceding siblings ...)
2021-03-03 13:06 ` [PATCH 3/3] docker: OpenSBI build job depends on OpenSBI container Philippe Mathieu-Daudé
@ 2021-03-03 17:55 ` Thomas Huth
3 siblings, 0 replies; 12+ messages in thread
From: Thomas Huth @ 2021-03-03 17:55 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Daniel P . Berrange, qemu-devel
Cc: Fam Zheng, Alex Bennée, Richard W . M . Jones,
Wainer dos Santos Moschetta, Bin Meng, Laszlo Ersek
On 03/03/2021 14.06, Philippe Mathieu-Daudé wrote:
> Following up Daniel's "fix build failures from incorrectly
> skipped container build jobs" effort (merged).
>
> Philippe Mathieu-Daudé (3):
> docker: Alpine build job depends on Alpine container
> docker: EDK2 build job depends on EDK2 container
> docker: OpenSBI build job depends on OpenSBI container
>
> .gitlab-ci.d/edk2.yml | 1 +
> .gitlab-ci.d/opensbi.yml | 1 +
> .gitlab-ci.yml | 2 ++
> 3 files changed, 4 insertions(+)
>
Thanks, queued now to my testing-next branch:
https://gitlab.com/thuth/qemu/-/commits/testing-next/
Thomas
^ permalink raw reply [flat|nested] 12+ messages in thread